Turn TouchControlType (TCT) into an enum class #25333
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion with global symbols or preprocessor definitions
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
from
40e1292 to
339773d
Compare
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
2 times, most recently
from
e90c213 to
4b9bb85
Compare
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
from
faa3233 to
5abfc61
Compare
|
I am sorry but I have decided to halt my activities on this PR for an indetermined amount of time. You are free to decide whether to continue it yourself. Thank you to the Marlin firmware community for providing this interesting playing ground for testing my ideas and vision. I hope that Marlin will continue to go towards the best 3D printing solution! Hopefully my ideas have inspired you on how to continue this software! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The TouchControlType enum for UI is a very risky subject when compiling with graphical display support. Each entry in the enum could collide with a platform-specific preprocessor macro. With this PR I want to help reduce said technical risk that could lead to future compilation failure. Using enum class is the recommended way for enum specification because the language grammar is more robust.
I did encounter a compilation failure due to that definition during my work so please take the subject of symbol collision in programming languages seriously.
Benefits
Stable codebase despite changes in platform packages or dependencies.
Related Issues
#24911