-
Notifications
You must be signed in to change notification settings - Fork 253
#7674: Ordering Sections on the Section-Specific Settings Table for Timed Assessments #7690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rametersExpect offenses
for more information, see https://pre-commit.ci
Pull Request Test Coverage Report for Build 18331556380Details
💛 - Coveralls |
Changelog.md
Outdated
- Fixed ordering of assignments in the Assignment dropdown menu and Assignment index page (#7642) | ||
- Updated Section model associations with appropriate dependent options to handle cascade deletion while preventing deletion when students exist (#7681) | ||
- Prevent grade change in the grades table for a Marks Spreadsheet, when scrolling up or down with mouse or keys (#7680) | ||
- Fixed ordering of sections in the section-specific settings table (#7674) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The number is incorrect: it should refer to the pull request number (7690), not the issue number.
Also please mention that this change is on the assignment settings form.
:anonymize_groups, | ||
:hide_unassigned_criteria | ||
]) | ||
params.expect(attribute: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the Rubocop configuration for pre-commit, though to be honest I'm not sure why you ran into this issue. In any case, please do a pull from upstream master and then revert these changes. They should no longer be flagged by Rubocop.
Nice work, @lizzie-liu! |
Proposed Changes
Fixed the timed assessment section-specific settings table to be alphanumerically ordered by section name.
Closes #7674
Screenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)
Type of Change
(Write an
X
or a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]
into a[x]
in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)