Skip to content

Conversation

lizzie-liu
Copy link
Contributor

@lizzie-liu lizzie-liu commented Oct 5, 2025

Proposed Changes

Fixed the timed assessment section-specific settings table to be alphanumerically ordered by section name.
Closes #7674

Screenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue) X
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@lizzie-liu lizzie-liu marked this pull request as ready for review October 5, 2025 00:11
@coveralls
Copy link
Collaborator

coveralls commented Oct 5, 2025

Pull Request Test Coverage Report for Build 18331556380

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.87%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/controllers/assignments_controller.rb 0 1 0.0%
Totals Coverage Status
Change from base Build 18331268749: 0.0%
Covered Lines: 42356
Relevant Lines: 45381

💛 - Coveralls

Changelog.md Outdated
- Fixed ordering of assignments in the Assignment dropdown menu and Assignment index page (#7642)
- Updated Section model associations with appropriate dependent options to handle cascade deletion while preventing deletion when students exist (#7681)
- Prevent grade change in the grades table for a Marks Spreadsheet, when scrolling up or down with mouse or keys (#7680)
- Fixed ordering of sections in the section-specific settings table (#7674)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The number is incorrect: it should refer to the pull request number (7690), not the issue number.

Also please mention that this change is on the assignment settings form.

:anonymize_groups,
:hide_unassigned_criteria
])
params.expect(attribute: [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the Rubocop configuration for pre-commit, though to be honest I'm not sure why you ran into this issue. In any case, please do a pull from upstream master and then revert these changes. They should no longer be flagged by Rubocop.

@david-yz-liu
Copy link
Collaborator

Nice work, @lizzie-liu!

@david-yz-liu david-yz-liu merged commit 50143bd into MarkUsProject:master Oct 8, 2025
7 checks passed
@david-yz-liu david-yz-liu added this to the v2.8.2 milestone Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Timed assessment section-specific settings table to have proper ordering

3 participants