remove redundant constructors (#4573)

SimonCropp · web-flow · commit f5141c2bf2eb · 2025-03-07T23:35:19.000-08:00
diff --git a/Source/Csla.Blazor.Test/ViewModelSaveAsyncErrorTests.cs b/Source/Csla.Blazor.Test/ViewModelSaveAsyncErrorTests.cs
@@ -123,10 +123,6 @@ public async Task SavingWithCancelledCancellationToken_ErrorEventIsInvoked()
 
     private class FakeBusy : Core.ITrackStatus
     {
-      public FakeBusy()
-      {
-      }
-
       public bool IsValid { get; set; }
 
       public bool IsSelfValid { get; set; }
diff --git a/Source/Csla.test/Asserter.cs b/Source/Csla.test/Asserter.cs
@@ -12,10 +12,6 @@ namespace UnitDriven
 {
   public class Asserter
   {
-    public Asserter()
-    {
-    }
-
     public void IsNull<T>(T value)
     {
       Assert.IsNull(value);
diff --git a/Source/Csla.test/Authorization/AuthTests.cs b/Source/Csla.test/Authorization/AuthTests.cs
@@ -715,10 +715,6 @@ protected override Task ExecuteAsync(IAuthorizationContext context, Cancellation
   [Serializable]
   public class RootList : BusinessListBase<RootList, ChildItem>
   {
-    public RootList()
-    {
-    }
-
     [Create]
     private void Create([Inject] IChildDataPortal<ChildItem> childDataPortal)
     {
diff --git a/Source/Csla.test/Basic/CollectionTests.cs b/Source/Csla.test/Basic/CollectionTests.cs
@@ -51,10 +51,6 @@ public void RootListGetRuleDescriptions()
   [Serializable]
   public class TestCollection : BusinessBindingListBase<TestCollection, TestItem>
   {
-    public TestCollection()
-    {
-    }
-
     [Create]
     private void Create()
     {
diff --git a/Source/Csla.test/Basic/CommandObject.cs b/Source/Csla.test/Basic/CommandObject.cs
@@ -35,9 +35,5 @@ protected void DataPortal_Execute()
         AProperty = "Executed";
       }
     }
-
-    public CommandObject()
-    {
-    }
   }
 }
diff --git a/Source/Csla.test/DataPortal/ChildEntityList.cs b/Source/Csla.test/DataPortal/ChildEntityList.cs
@@ -11,10 +11,6 @@ namespace Csla.Test.DataBinding
   [Serializable]
   public class ChildEntityList : BusinessBindingListBase<ChildEntityList, ChildEntity>
   {
-    public ChildEntityList()
-    {
-    }
-
     #region "Criteria"
 
     [Serializable]
diff --git a/Source/Csla.test/EditableRootList/ERitem.cs b/Source/Csla.test/EditableRootList/ERitem.cs
@@ -18,9 +18,6 @@ public string Data
       set { SetProperty(DataProperty, value); }
     }
 
-    public ERitem()
-    { }
-
     [Create]
     private void Create()
     {
diff --git a/Source/Csla.test/Fakes/Server/BusyStatus/ItemWithAsynchRule.cs b/Source/Csla.test/Fakes/Server/BusyStatus/ItemWithAsynchRule.cs
@@ -13,8 +13,6 @@ namespace Csla.Testing.Business.BusyStatus
   [Serializable]
   public class ItemWithAsynchRule : BusinessBase<ItemWithAsynchRule>
   {
-    public ItemWithAsynchRule() { }
-
     private static PropertyInfo<string> IdProperty = RegisterProperty<string>(c => c.Id);
 
     public string Id
diff --git a/Source/Csla.test/Fakes/Server/DataPortal/AsyncPortalWithCulture.cs b/Source/Csla.test/Fakes/Server/DataPortal/AsyncPortalWithCulture.cs
@@ -39,8 +39,6 @@ public string CurrentCulture
     public static PropertyInfo<string> CurrentCultureProperty =
       RegisterProperty<string>(new PropertyInfo<string>("CurrentCulture"));
 
-    public AsyncPortalWithCulture() { }
-
     [RunLocal]
     [Create]
     private void Create()
diff --git a/Source/Csla.test/Fakes/Server/DataPortal/PrimitiveCriteriaSingle.cs b/Source/Csla.test/Fakes/Server/DataPortal/PrimitiveCriteriaSingle.cs
@@ -37,9 +37,6 @@ protected override object GetIdValue()
 
     #endregion
 
-    public PrimitiveCriteriaSingle()
-    { }
-
     #region Data Access
 
     #region DataPortal_Create
diff --git a/Source/Csla.test/Fakes/Server/DataPortal/Single.cs b/Source/Csla.test/Fakes/Server/DataPortal/Single.cs
@@ -31,9 +31,6 @@ public string MethodCalled
       set { SetProperty(MethodCalledProperty, value); }
     }
 
-    public Single()
-    { }
-
     [Create]
     protected void DataPortal_Create()
     {
diff --git a/Source/Csla.test/FieldManager/Async/ChildList.cs b/Source/Csla.test/FieldManager/Async/ChildList.cs
@@ -16,10 +16,6 @@ public static Task<ChildList> GetListAsync(IChildDataPortal<ChildList> childData
       return childDataPortal.FetchChildAsync();
     }
 
-    public ChildList()
-    {
-    }
-
     public object MyParent
     {
       get { return Parent; }
diff --git a/Source/Csla.test/LazyLoad/AChild.cs b/Source/Csla.test/LazyLoad/AChild.cs
@@ -23,10 +23,6 @@ public Guid Id
       get { return base.EditLevel; }
     }
 
-    public AChild()
-    {
-    }
-
     [Create]
     [CreateChild]
     private void Create()
diff --git a/Source/Csla.test/Linq/LinqObservableCollectionTest.cs b/Source/Csla.test/Linq/LinqObservableCollectionTest.cs
@@ -448,10 +448,6 @@ public void ClearView()
   [Serializable]
   public class TestList : BusinessListBase<TestList, TestItem>
   {
-    public TestList()
-    {
-    }
-
     public static TestList NewTestList(IDataPortal<TestList> dataPortal)
     {
       return dataPortal.Create();
diff --git a/Source/Csla.test/PropertyGetSet/ChildList.cs b/Source/Csla.test/PropertyGetSet/ChildList.cs
@@ -11,9 +11,6 @@ namespace Csla.Test.PropertyGetSet
   [Serializable]
   public class ChildList : BusinessListBase<ChildList, EditableGetSet>
   {
-    public ChildList()
-    { }
-
     public static ChildList NewObject(IDataPortal<ChildList> dataPortal)
     {
       return dataPortal.Create();
diff --git a/Source/Csla.test/PropertyGetSet/EditableGetSetBase.cs b/Source/Csla.test/PropertyGetSet/EditableGetSetBase.cs
@@ -31,10 +31,6 @@ public string Base
   public class EditableGetSetNFIBase<T> : EditableGetSetTopNFIBase<T>
     where T : EditableGetSetNFIBase<T>
   {
-    public EditableGetSetNFIBase()
-    {
-    }
-
     public static PropertyInfo<string> BaseProperty = RegisterProperty<string>(new PropertyInfo<string>("Base", "Base"));
     public string Base
     {
diff --git a/Source/Csla.test/PropertyGetSet/EditableGetSetTopBase.cs b/Source/Csla.test/PropertyGetSet/EditableGetSetTopBase.cs
@@ -31,10 +31,6 @@ public string TopBase
   public class EditableGetSetTopNFIBase<T> : BusinessBase<T>
     where T : EditableGetSetTopNFIBase<T>
   {
-    public EditableGetSetTopNFIBase()
-    {
-    }
-
     public static PropertyInfo<string> TopBaseProperty = RegisterProperty<string>(new PropertyInfo<string>("TopBase", "TopBase"));
     public string TopBase
     {
diff --git a/Source/Csla.test/Serialization/BinaryReaderWriterTestClass.cs b/Source/Csla.test/Serialization/BinaryReaderWriterTestClass.cs
@@ -10,11 +10,6 @@ public enum RandomEnum
   [Serializable]
   public class BinaryReaderWriterTestClassList : BusinessListBase<BinaryReaderWriterTestClassList, BinaryReaderWriterTestClass>
   {
-    public BinaryReaderWriterTestClassList()
-    {
-
-    }
-
     public void Setup()
     {
     }
diff --git a/Source/Csla.test/ValidationRules/AsyncRuleRoot.cs b/Source/Csla.test/ValidationRules/AsyncRuleRoot.cs
@@ -36,10 +36,6 @@ public static AsyncRuleRoot NewRoot(IDataPortal<AsyncRuleRoot> dataPortal)
       return dataPortal.Create();
     }
 
-    public AsyncRuleRoot()
-    {
-    }
-
     protected override void AddBusinessRules()
     {
       BusinessRules.AddRule(new Rules.CommonRules.Required(CustomerNumberProperty));
diff --git a/Source/Csla.test/ValidationRules/ValidationTests.cs b/Source/Csla.test/ValidationRules/ValidationTests.cs
@@ -817,9 +817,6 @@ public string Value1
       set { SetProperty(Value1Property, value); }
     }
 
-    public DirtyAfterOutValueChangesProperty() 
-    { }
-
     protected override void AddBusinessRules()
     {
       base.AddBusinessRules();
diff --git a/Source/csla.netcore.test/Basic/CommandObject.cs b/Source/csla.netcore.test/Basic/CommandObject.cs
@@ -30,9 +30,5 @@ protected void DataPortal_Execute()
         AProperty = "Executed";
       }
     }
-
-    public CommandObject()
-    {
-    }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -123,10 +123,6 @@ public async Task SavingWithCancelledCancellationToken_ErrorEventIsInvoked()`
`123`	`123`
`124`	`124`	`private class FakeBusy : Core.ITrackStatus`
`125`	`125`	`{`
`126`		`- public FakeBusy()`
`127`		`- {`
`128`		`- }`
`129`		`-`
`130`	`126`	`public bool IsValid { get; set; }`
`131`	`127`
`132`	`128`	`public bool IsSelfValid { get; set; }`
Original file line number	Diff line number	Diff line change
`@@ -12,10 +12,6 @@ namespace UnitDriven`
`12`	`12`	`{`
`13`	`13`	`public class Asserter`
`14`	`14`	`{`
`15`		`- public Asserter()`
`16`		`- {`
`17`		`- }`
`18`		`-`
`19`	`15`	`public void IsNull<T>(T value)`
`20`	`16`	`{`
`21`	`17`	`Assert.IsNull(value);`
Original file line number	Diff line number	Diff line change
`@@ -715,10 +715,6 @@ protected override Task ExecuteAsync(IAuthorizationContext context, Cancellation`
`715`	`715`	`[Serializable]`
`716`	`716`	`public class RootList : BusinessListBase<RootList, ChildItem>`
`717`	`717`	`{`
`718`		`- public RootList()`
`719`		`- {`
`720`		`- }`
`721`		`-`
`722`	`718`	`[Create]`
`723`	`719`	`private void Create([Inject] IChildDataPortal<ChildItem> childDataPortal)`
`724`	`720`	`{`
Original file line number	Diff line number	Diff line change
`@@ -51,10 +51,6 @@ public void RootListGetRuleDescriptions()`
`51`	`51`	`[Serializable]`
`52`	`52`	`public class TestCollection : BusinessBindingListBase<TestCollection, TestItem>`
`53`	`53`	`{`
`54`		`- public TestCollection()`
`55`		`- {`
`56`		`- }`
`57`		`-`
`58`	`54`	`[Create]`
`59`	`55`	`private void Create()`
`60`	`56`	`{`
Original file line number	Diff line number	Diff line change
`@@ -35,9 +35,5 @@ protected void DataPortal_Execute()`
`35`	`35`	`AProperty = "Executed";`
`36`	`36`	`}`
`37`	`37`	`}`
`38`		`-`
`39`		`- public CommandObject()`
`40`		`- {`
`41`		`- }`
`42`	`38`	`}`
`43`	`39`	`}`
Original file line number	Diff line number	Diff line change
`@@ -18,9 +18,6 @@ public string Data`
`18`	`18`	`set { SetProperty(DataProperty, value); }`
`19`	`19`	`}`
`20`	`20`
`21`		`- public ERitem()`
`22`		`- { }`
`23`		`-`
`24`	`21`	`[Create]`
`25`	`22`	`private void Create()`
`26`	`23`	`{`
Original file line number	Diff line number	Diff line change
`@@ -13,8 +13,6 @@ namespace Csla.Testing.Business.BusyStatus`
`13`	`13`	`[Serializable]`
`14`	`14`	`public class ItemWithAsynchRule : BusinessBase<ItemWithAsynchRule>`
`15`	`15`	`{`
`16`		`- public ItemWithAsynchRule() { }`
`17`		`-`
`18`	`16`	`private static PropertyInfo<string> IdProperty = RegisterProperty<string>(c => c.Id);`
`19`	`17`
`20`	`18`	`public string Id`
Original file line number	Diff line number	Diff line change
`@@ -31,9 +31,6 @@ public string MethodCalled`
`31`	`31`	`set { SetProperty(MethodCalledProperty, value); }`
`32`	`32`	`}`
`33`	`33`
`34`		`- public Single()`
`35`		`- { }`
`36`		`-`
`37`	`34`	`[Create]`
`38`	`35`	`protected void DataPortal_Create()`
`39`	`36`	`{`
Original file line number	Diff line number	Diff line change
`@@ -16,10 +16,6 @@ public static Task<ChildList> GetListAsync(IChildDataPortal<ChildList> childData`
`16`	`16`	`return childDataPortal.FetchChildAsync();`
`17`	`17`	`}`
`18`	`18`
`19`		`- public ChildList()`
`20`		`- {`
`21`		`- }`
`22`		`-`
`23`	`19`	`public object MyParent`
`24`	`20`	`{`
`25`	`21`	`get { return Parent; }`
Original file line number	Diff line number	Diff line change
`@@ -448,10 +448,6 @@ public void ClearView()`
`448`	`448`	`[Serializable]`
`449`	`449`	`public class TestList : BusinessListBase<TestList, TestItem>`
`450`	`450`	`{`
`451`		`- public TestList()`
`452`		`- {`
`453`		`- }`
`454`		`-`
`455`	`451`	`public static TestList NewTestList(IDataPortal<TestList> dataPortal)`
`456`	`452`	`{`
`457`	`453`	`return dataPortal.Create();`