faster string lookups (#4553)

Author: SimonCropp

Source/Csla.Web/CslaDataSource.cs

@@ -138,7 +138,7 @@ internal static Type GetType(
         // explicit assembly name provided
         result = Type.GetType($"{typeName}, {typeAssemblyName}", true, true);
       }
-      else if (typeName.IndexOf(",") > 0)
+      else if (typeName.Contains(','))
       {
         // assembly qualified type name provided
         result = Type.GetType(typeName, true, true);

Source/Csla.Web/Design/CslaDataSourceConfiguration.cs

@@ -70,12 +70,12 @@ private void DiscoverTypes()
           // adds the types to the list
           foreach (Type type in types)
           {
-            if (type.Assembly.FullName.Substring(0, type.Assembly.FullName.IndexOf(",")) != "Csla" &&
+            if (type.Assembly.FullName.Substring(0, type.Assembly.FullName.IndexOf(',')) != "Csla" &&
               typeof(Core.IBusinessObject).IsAssignableFrom(type))
             {
               string name = type.AssemblyQualifiedName;
               if (name.Substring(name.Length - 19, 19) == "PublicKeyToken=null")
-                name = name.Substring(0, name.IndexOf(",", name.IndexOf(",") + 1));
+                name = name.Substring(0, name.IndexOf(',', name.IndexOf(',') + 1));
               TypeComboBox.Items.Add(name);
             }
           }

Source/Csla.Xaml.Shared/PropertyInfo.cs

@@ -252,9 +252,10 @@ private void SetSource()
         {
           while (BindingPath.Contains(".") && Source != null)
           {
-            var refName = BindingPath.Substring(0, BindingPath.IndexOf("."));
+            var dotIndex = BindingPath.IndexOf('.');
+            var refName = BindingPath.Substring(0, dotIndex);
             _sources.Add(new SourceReference(this, Source, refName));
-            BindingPath = BindingPath.Substring(BindingPath.IndexOf(".") + 1);
+            BindingPath = BindingPath.Substring(dotIndex + 1);
             Source = MethodCaller.CallPropertyGetter(Source, refName);
           }
         }
@@ -416,7 +417,7 @@ protected virtual void SetSource(object dataItem)
         }
       }
 
-      if (BindingPath.IndexOf('.') > 0)
+      if (BindingPath.Contains('.'))
         BindingPath = BindingPath.Substring(BindingPath.LastIndexOf('.') + 1);
 
       if (isDataLoaded)
@@ -460,18 +461,19 @@ protected object GetRealSource(object source, string bindingPath)
     {
       if (source is ICollectionView icv)
         source = icv.CurrentItem;
-      if (source != null && bindingPath.IndexOf('.') > 0)
+      var dotIndex = bindingPath.IndexOf('.');
+      if (source != null && dotIndex > 0)
       {
-        var firstProperty = bindingPath.Substring(0, bindingPath.IndexOf('.'));
+        var firstProperty = bindingPath.Substring(0, dotIndex);
         var p = MethodCaller.GetProperty(source.GetType(), firstProperty);
         if (p != null)
         {
          source = GetRealSource(
           MethodCaller.GetPropertyValue(source, p),
-          bindingPath.Substring(bindingPath.IndexOf('.') + 1));
+          bindingPath.Substring(dotIndex + 1));
         }
       }
-        
+
       return source;
     }
 
@@ -484,15 +486,16 @@ protected PropertyPath GetRelativePath(object source, string bindingPath)
     {
       if (source != null)
       {
-        if (bindingPath.IndexOf('.') > 0)
+        var dotIndex = bindingPath.IndexOf('.');
+        if (dotIndex > 0)
         {
-          var firstProperty = bindingPath.Substring(0, bindingPath.IndexOf('.'));
+          var firstProperty = bindingPath.Substring(0, dotIndex);
           var p = MethodCaller.GetProperty(source.GetType(), firstProperty);
 
           if (p != null)
             return new PropertyPath(firstProperty);
           else
-            return GetRelativePath(source, bindingPath.Substring(bindingPath.IndexOf('.') + 1));
+            return GetRelativePath(source, bindingPath.Substring(dotIndex + 1));
         }
         else
           return new PropertyPath(bindingPath);

Source/Csla.Xaml.Shared/PropertyStatus.cs

@@ -220,8 +220,9 @@ private void SetBindingValues()
     protected object GetRealSource(object source, string bindingPath)
     {
       var firstProperty = string.Empty;
-      if (bindingPath.IndexOf('.') > 0)
-        firstProperty = bindingPath.Substring(0, bindingPath.IndexOf('.'));
+      var dotIndex = bindingPath.IndexOf('.');
+      if (dotIndex > 0)
+        firstProperty = bindingPath.Substring(0, dotIndex);
 
       if (source is ICollectionView icv && firstProperty != "CurrentItem")
         source = icv.CurrentItem;
@@ -230,7 +231,7 @@ protected object GetRealSource(object source, string bindingPath)
         var p = MethodCaller.GetProperty(source.GetType(), firstProperty);
         return GetRealSource(
           MethodCaller.GetPropertyValue(source, p),
-          bindingPath.Substring(bindingPath.IndexOf('.') + 1));
+          bindingPath.Substring(dotIndex + 1));
       }
       else
         return source;