Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDEV-34703 followup - reenable Innodb bulk load in mariadb-import #3774

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vaintroub
Copy link
Member

@vaintroub vaintroub commented Jan 17, 2025

Since bulk load is fixed, in some newer versions of the server, reenable it, after checking that MDEV-34703 was really fixed in server.

  • The Jira issue number for this PR is: MDEV-34703

Description

Reenabled Innodb bulk load in the mariadb-import for the server versions where MDEV-34703 was fixed.

Release Notes

mariadb-import will load Innodb tables. faster (for new versions of the server)

How can this PR be tested?

The only useful test is loading a large multi-GB Innodb tables. This excludes the MTR testing.

If the changes are not amenable to automated testing, please explain why not and carefully describe how to test manually.

Basing the PR against the correct MariaDB version

  • This is a new feature or a refactoring, and the PR is based against the main branch.
  • This is a bug fix, and the PR is based against the earliest maintained branch in which the bug can be reproduced.

PR quality check

  • I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

Since bulk load is fixed, in some newer versions of the server,
reenable it, after checking whether MDEV-34703 was really fixed in server.
@vaintroub vaintroub enabled auto-merge (rebase) January 21, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants