Make sure "logger" message arguments are not interpreted as command line switches #3492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gument warnings Added missing logger command argument quoting. And fixed a wsrep_log call typo.
…gument warnings Make sure that even a quoted argument starting with '-' is not interpreted as a command line option by adding '--' marker before message text
grooverdan
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a case where logger would report "invalid option 'r'" as the actual output was "ls -l" output
Properly quoting the subshell output, and adding '--' before the message argument to make sure it does not get interpreted as command line switch even when starting with a '-', prevents this from happening again.
Release Notes
Not relevant enough to be mentioned in release notes I say.
How can this PR be tested?
I only noticed this when trying to upgrade a Galera cluster from 10.x to 11.x, had never seen the "invalid option" output in error logs before. So it is rather tricky to actually test, but should be easy to be reviewed as it is just basic shell stuff.
Basing the PR against the correct MariaDB version
mainbranch.PR quality check