Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update THIRDPARTY license file to reflect reality #3475

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

FaramosCZ
Copy link
Contributor

Description

There are several files under the GPL with BISON expection license.

However none of them are 'GPL-2.0-or-later' today, all of them are 'GPL-3.0-or-later' now, and none of them have '... version 1.24 of Bison' and all of them have '... version 2.2 of Bison'.

Search done by using:
grep -i -e "of bison" -r .
for quick file listing,

and by:
grep --before=20 --after=20 -i -e "bison" -r . | grep --after=2 --before=20 -i exception
to list the whole license blocks (with the GPL part), but it contains few false positive results (matched code instead of license block)

Release Notes

Nothing?

How can this PR be tested?

Use GREP commands listed above,
or try some of your own to try to disprove my findings.

Basing the PR against the correct MariaDB version

  • This is a new feature or a refactoring, and the PR is based against the latest MariaDB development branch.
  • This is a bug fix, and the PR is based against the earliest maintained branch in which the bug can be reproduced.

PR quality check

  • I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

There are several files under the GPL with BISON expection license.

However none of them are 'GPL-2.0-or-later' today,
all of them are 'GPL-3.0-or-later' now,
and none of them have '... version 1.24 of Bison',
and all of them have '... version 2.2 of Bison'.

Search done by using:
  grep -i -e "of bison" -r .
for quick file listing,

and by:
  grep --before=20 --after=20 -i -e "bison" -r . | grep --after=2 --before=20 -i exception
to list the whole license blocks (with the GPL part),
but it contains few false positive results
(matched code instead of license block)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant