Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array chapter #46

Merged
merged 12 commits into from
Sep 6, 2024
Merged

Array chapter #46

merged 12 commits into from
Sep 6, 2024

Conversation

condekind
Copy link
Contributor

This PR introduces a new chapter about arrays.

Copy link
Owner

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @condekind, this looks on the right track ! i know this is still in draft, but just leaving an early comment in case it's helpful

docs/arrays.md Outdated Show resolved Hide resolved
@condekind condekind marked this pull request as ready for review September 5, 2024 14:12
Copy link
Owner

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @condekind ! 🙌

Just a comment - could you add a test which involves midpoint_2d please? just to ensure it keeps working the same way in the future


I've reworded the "2d arrays" a bit to just "arrays" - I get that the array represents a 2d point, but I think technically if each row has say (2, 4) (x-coord, y-coord) then [2, 4] is a 1-d array of length 2?

@condekind
Copy link
Contributor Author

Nice one @condekind ! 🙌

Just a comment - could you add a test which involves midpoint_2d please? just to ensure it keeps working the same way in the future

I've reworded the "2d arrays" a bit to just "arrays" - I get that the array represents a 2d point, but I think technically if each row has say (2, 4) (x-coord, y-coord) then [2, 4] is a 1-d array of length 2?

Thanks for catching that, you're right!

I added a simple test now, see if that's enough (it uses some of the same points as the ones in run.py, I hope that's fine)

Copy link
Owner

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks so much @condekind !

@MarcoGorelli MarcoGorelli merged commit b3f27e6 into MarcoGorelli:main Sep 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants