Merge pull request #97 from kenodegard/nested-deepfreeze

`deepfreeze` must not modify original object
Marco-Sulla · Apr 13, 2024 · de41bda · de41bda
2 parents d92551a + f448ba8
commit de41bda
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/src/frozendict/cool.py b/src/frozendict/cool.py
@@ -280,8 +280,8 @@ def deepfreeze(
 
     o_copy = copy(o)
 
-    for k, v in getItems(o)(o_copy):
-        o[k] = deepfreeze(
+    for k, v in getItems(o_copy)(o_copy):
+        o_copy[k] = deepfreeze(
             v,
             custom_converters = custom_converters,
             custom_inverse_converters = custom_inverse_converters
@@ -295,7 +295,7 @@ def deepfreeze(
         else:
             raise
 
-    return freeze(o)
+    return freeze(o_copy)
 
 
 __all__ = (

diff --git a/test/test_freeze.py b/test/test_freeze.py
@@ -181,4 +181,14 @@ def test_prefer_forward():
             custom_inverse_converters={FrozenSeqA: MutableSeq}
             )[0],
         FrozenSeqB
-        )
+        )
+
+def test_original_immutate():
+    unfrozen = {
+        "int": 1,
+        "nested": {"int": 1},
+    }
+
+    frozen = cool.deepfreeze(unfrozen)
+
+    assert type(unfrozen["nested"]) is dict