Skip to content

Commit

Permalink
Update
Browse files Browse the repository at this point in the history
  • Loading branch information
@mbtools
mbtools committed Dec 19, 2023
1 parent a9af81c commit e002746
Show file tree
Hide file tree
Showing 3 changed files with 29 additions and 51 deletions.
11 changes: 4 additions & 7 deletions src/#mbtools#cl_test.clas.abap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,12 @@ CLASS /mbtools/cl_test DEFINITION

METHODS initialize
IMPORTING
iv_test TYPE abap_bool.
test TYPE abap_bool.

Check failure on line 16 in src/#mbtools#cl_test.clas.abap

View check run for this annotation

abaplint / abaplint

Method parameter name does not match pattern ^I._.+$: test 

https://rules.abaplint.org/method_parameter_names
METHODS pbo.
METHODS pai
CHANGING
!cv_ok_code TYPE sy-ucomm.
!ok_code TYPE sy-ucomm.

Check failure on line 20 in src/#mbtools#cl_test.clas.abap

View check run for this annotation

abaplint / abaplint

Method parameter name does not match pattern ^C._.+$: ok_code 

https://rules.abaplint.org/method_parameter_names
METHODS screen.

PROTECTED SECTION.
PRIVATE SECTION.

Expand All @@ -31,7 +30,7 @@ CLASS /mbtools/cl_test IMPLEMENTATION.


METHOD initialize.
IF iv_test = abap_true.
IF test = abap_true.
MESSAGE 'Test ON' TYPE 'I'.
ELSE.
MESSAGE 'Test OFF' TYPE 'I'.
Expand All @@ -40,16 +39,14 @@ CLASS /mbtools/cl_test IMPLEMENTATION.


METHOD pai.
CLEAR cv_ok_code.
CLEAR ok_code.
ENDMETHOD.


METHOD pbo.

Check warning on line 46 in src/#mbtools#cl_test.clas.abap

View check run for this annotation

abaplint / abaplint

Empty METHOD 

https://rules.abaplint.org/method_length
RETURN.
ENDMETHOD.


METHOD screen.

Check warning on line 50 in src/#mbtools#cl_test.clas.abap

View check run for this annotation

abaplint / abaplint

Empty METHOD 

https://rules.abaplint.org/method_length
ASSERT 0 = 0.
ENDMETHOD.
ENDCLASS.
37 changes: 18 additions & 19 deletions src/#mbtools#mbt_test.prog.abap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ COMMENT /1(77) sc_t200,
COMMENT /1(77) sc_t201,
END OF BLOCK b200,
BEGIN OF BLOCK b210 WITH FRAME.
PARAMETERS:
p_test AS CHECKBOX DEFAULT 'X'.
PARAMETERS p_test AS CHECKBOX DEFAULT 'X'.
SELECTION-SCREEN:
END OF BLOCK b210,
END OF SCREEN 200.
Expand Down Expand Up @@ -67,24 +66,24 @@ CONSTANTS:
c_title TYPE string VALUE /mbtools/cl_tool_bc_test=>c_tool-title.

DATA:
gv_ok_code TYPE sy-ucomm,
go_tool TYPE REF TO /mbtools/cl_tool,
go_screen TYPE REF TO /mbtools/cl_screen,
go_app TYPE REF TO /mbtools/cl_test.
ok_code TYPE sy-ucomm,
tool TYPE REF TO /mbtools/cl_tool,

Check failure on line 70 in src/#mbtools#mbt_test.prog.abap

View check run for this annotation

abaplint / abaplint

Variable "TOOL" contains unknown: REF, unable to resolve /mbtools/cl_tool 

https://rules.abaplint.org/unknown_types
screen TYPE REF TO /mbtools/cl_screen,

Check failure on line 71 in src/#mbtools#mbt_test.prog.abap

View check run for this annotation

abaplint / abaplint

Variable "SCREEN" contains unknown: REF, unable to resolve /mbtools/cl_screen 

https://rules.abaplint.org/unknown_types
app TYPE REF TO /mbtools/cl_test.

*-----------------------------------------------------------------------

MODULE pbo_100 OUTPUT.

go_screen->banner( abap_false ).
screen->banner( abap_false ).

Check failure on line 78 in src/#mbtools#mbt_test.prog.abap

View check run for this annotation

abaplint / abaplint

Method "banner" not found, methodCallChain 

https://rules.abaplint.org/check_syntax

go_app->pbo( ).
app->pbo( ).

ENDMODULE.

MODULE pai_100 INPUT.

go_app->pai( CHANGING cv_ok_code = gv_ok_code ).
app->pai( CHANGING cv_ok_code = ok_code ).

Check failure on line 86 in src/#mbtools#mbt_test.prog.abap

View check run for this annotation

abaplint / abaplint

Method changing parameter "CV_OK_CODE" does not exist 

https://rules.abaplint.org/check_syntax

ENDMODULE.

Expand All @@ -95,12 +94,12 @@ INITIALIZATION.
RETURN.
ENDIF.

CREATE OBJECT go_app.
CREATE OBJECT app.

go_tool = /mbtools/cl_tool_manager=>factory( c_title ).
go_screen = /mbtools/cl_screen=>factory( c_title ).
tool = /mbtools/cl_tool_manager=>factory( c_title ).

Check failure on line 99 in src/#mbtools#mbt_test.prog.abap

View check run for this annotation

abaplint / abaplint

Class /mbtools/cl_tool_manager not found 

https://rules.abaplint.org/check_syntax
screen = /mbtools/cl_screen=>factory( c_title ).

Check failure on line 100 in src/#mbtools#mbt_test.prog.abap

View check run for this annotation

abaplint / abaplint

Class /mbtools/cl_screen not found 

https://rules.abaplint.org/check_syntax

go_screen->init(
screen->init(

Check failure on line 102 in src/#mbtools#mbt_test.prog.abap

View check run for this annotation

abaplint / abaplint

Method "init" not found, methodCallChain 

https://rules.abaplint.org/check_syntax
IMPORTING
ev_text = sc_t001
ev_about = sc_tab9
Expand All @@ -112,7 +111,7 @@ INITIALIZATION.
ev_home = sc_home
ev_lice = sc_lice ).

sc_tab2 = go_screen->header(
sc_tab2 = screen->header(

Check failure on line 114 in src/#mbtools#mbt_test.prog.abap

View check run for this annotation

abaplint / abaplint

Method "header" not found, methodCallChain 

https://rules.abaplint.org/check_syntax
iv_icon = icon_color
iv_text = 'Test' ).

Expand All @@ -123,17 +122,17 @@ INITIALIZATION.

AT SELECTION-SCREEN.

go_app->screen( ).
app->screen( ).

go_screen->ucomm( sscrfields-ucomm ).
screen->ucomm( sscrfields-ucomm ).

Check failure on line 127 in src/#mbtools#mbt_test.prog.abap

View check run for this annotation

abaplint / abaplint

Method "ucomm" not found, methodCallChain 

https://rules.abaplint.org/check_syntax

*-----------------------------------------------------------------------

AT SELECTION-SCREEN OUTPUT.

go_screen->banner( ).
screen->banner( ).

Check failure on line 133 in src/#mbtools#mbt_test.prog.abap

View check run for this annotation

abaplint / abaplint

Method "banner" not found, methodCallChain 

https://rules.abaplint.org/check_syntax

go_app->screen( ).
app->screen( ).

*-----------------------------------------------------------------------

Expand All @@ -142,4 +141,4 @@ START-OF-SELECTION.
LOG-POINT ID /mbtools/bc SUBKEY c_title FIELDS sy-datum sy-uzeit sy-uname.

" Setup tree
go_app->initialize( p_test ).
app->initialize( p_test ).
32 changes: 7 additions & 25 deletions src/#mbtools#mbt_test.prog.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,34 +12,16 @@
<UCCHECK>X</UCCHECK>
</PROGDIR>
<TPOOL>
<item>
<ID>I</ID>
<KEY>001</KEY>
<ENTRY>Login</ENTRY>
<LENGTH>50</LENGTH>
</item>
<item>
<ID>I</ID>
<KEY>002</KEY>
<ENTRY>URL</ENTRY>
<LENGTH>50</LENGTH>
</item>
<item>
<ID>I</ID>
<KEY>003</KEY>
<ENTRY>User</ENTRY>
<LENGTH>50</LENGTH>
</item>
<item>
<ID>I</ID>
<KEY>004</KEY>
<ENTRY>Password</ENTRY>
<LENGTH>50</LENGTH>
</item>
<item>
<ID>R</ID>
<ENTRY>MBT Test</ENTRY>
<LENGTH>18</LENGTH>
<LENGTH>8</LENGTH>
</item>
<item>
<ID>S</ID>
<KEY>P_TEST</KEY>
<ENTRY>Test Run</ENTRY>
<LENGTH>16</LENGTH>
</item>
</TPOOL>
</asx:values>
Expand Down

0 comments on commit e002746

Please sign in to comment.