Feat: add helm chart#1
Open
razbroc wants to merge 8 commits into
Open
Conversation
CL-SHLOMIKONCHA
requested changes
Mar 10, 2026
There was a problem hiding this comment.
add .gitignore -> add .tgz files to gitignore
There was a problem hiding this comment.
add to .tgz files to gitignore
| TELEMETRY_TRACING_ENABLED: 'true' | ||
| TELEMETRY_TRACING_URL: {{ $tracing.url }} | ||
| {{ end }} | ||
| {{ if $metrics.enabled }} |
There was a problem hiding this comment.
$metrics.enabled -> this scope should be irrelevant as mclabels should take care of those envs once they configured
| {{- $headerList = uniq $headerList -}} | ||
| {{- quote (join "," $headerList) -}} | ||
| {{- end -}} | ||
| {{- end -}} No newline at end of file |
| {{- end -}} | ||
| {{- end -}} | ||
|
|
||
| {{- define "map-proxy.cors.allowedHeaders" -}} |
There was a problem hiding this comment.
change to "mapproxy" as all helpers convention
| .vscode/ | ||
| *.txt | ||
| *local.json | ||
| *local.yaml No newline at end of file |
| # Copy application code and entrypoint (single layer, correct ownership) | ||
| COPY --chown=mapproxy:mapproxy src/app.py /mapproxy/app.py | ||
| COPY --chown=mapproxy:mapproxy entrypoint.sh /mapproxy/entrypoint.sh | ||
| COPY --chown=mapproxy:mapproxy src/app.py /mapproxy/app.py |
| COPY --chown=mapproxy:mapproxy src/app.py /mapproxy/app.py | ||
| COPY --chown=mapproxy:mapproxy entrypoint.sh /mapproxy/entrypoint.sh | ||
| COPY --chown=mapproxy:mapproxy src/app.py /mapproxy/app.py | ||
| COPY --chown=mapproxy:mapproxy entrypoint.sh /mapproxy/entrypoint.sh |
There was a problem hiding this comment.
do we need this file? does not includes in mapproxy image?
Collaborator
Author
There was a problem hiding this comment.
we run this file as entrypoint in docker file see ENTRYPOINT ["/mapproxy/entrypoint.sh"]
…orage' in Helm templates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a comprehensive Helm chart for deploying the MapProxy service, along with significant improvements to configuration, logging, and startup logic. The changes add Helm chart structure, templated configuration files for Nginx and uWSGI, and enhance the container entrypoint to better support Kubernetes deployments. The most important changes are grouped below:
Helm Chart Introduction and Structure
Chart.yamlwith dependencies onnginxandmclabelscharts, enabling managed, configurable Kubernetes deployments..helmignoreto exclude unnecessary files from chart packaging._helpers.tplwith reusable template helpers for naming, labels, environment, and cloud provider settings.Configuration and Template Enhancements
nginx.conf,mapProxyUwsgi.ini,default.conf,nginx.mapproxy.conf,nginx.mapproxy.wmts.conf) to support flexible, environment-driven deployments and advanced features like caching, JWT authentication, and metrics. [1] [2] [3] [4] [5]log.ini,log_format.conf) to enable structured, JSON-formatted logs with support for OpenTelemetry and customizable log levels. [1] [2]Entrypoint and Startup Logic
entrypoint.shto create necessary directories, validate the presence of the Helm-provideduwsgi.ini, and launch uWSGI using the mounted config, improving error handling and compatibility with Kubernetes ConfigMaps.