feat: add pagination support to all list endpoints MAPCO-9304#263
Open
ronenkapelian wants to merge 1 commit into
Open
feat: add pagination support to all list endpoints MAPCO-9304#263ronenkapelian wants to merge 1 commit into
ronenkapelian wants to merge 1 commit into
Conversation
|
🎫 Related Jira Issue: MAPCO-9304 |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
page/page_sizequery parameters to all 5 list endpoints. Response shape changes from a raw array to{ total, items }.Endpoints affected
GET /v1/jobsGET /v1/stagesGET /v1/jobs/:jobId/stagesGET /v1/tasksGET /v1/stages/:stageId/tasksChanges
openapi_v1.yaml— source of truth updated with pagination params and paginated response schemas;openapi3.yamlandsrc/openapi.d.tsregeneratedsrc/common/utils/pagination.ts— sharedpaginationParamsToTakeAndSkip()utilityfindMany+countin parallel and return{ total, items }eslint.config.mjs— allowlist forpage_sizesnake_case destructuringBreaking change
T[]→{ total: number; items: T[] }on all 5 endpoints.Consumer migration:
response→response.itemsresponse.length→response.totalRelease as
0.3.0.