feat: adjust e2e to pagination api MAPCO-9304 - #9
Open
ronenkapelian wants to merge 7 commits into
Open
Conversation
…sk requests MAPCO-9289
…or pagination API
ronenkapelian
changed the title
…tructure handling
CptSchnitz
requested changes
Jul 28, 2026
| "homepage": "https://github.com/MapColonies/jobnik-e2e#readme", | ||
| "dependencies": { | ||
| "@map-colonies/jobnik-sdk": "^0.3.0", | ||
| "@map-colonies/jobnik-sdk": "file:../jobnik-sdk/map-colonies-jobnik-sdk-0.3.0.tgz", |
Contributor
There was a problem hiding this comment.
is this on purpose or just for your tests?
Contributor
Author
There was a problem hiding this comment.
fixed with new release of sdk 1.0.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List endpoints now return
{ total, items }instead of a raw array (breakingchange introduced in jobnik-manager PR #263).
Changes:
tests/multipleStagesWorkflow.spec.ts— updateGET /v1/jobs/{jobId}/stagesusages to access
.itemsand.totalviaPaginatedResponsecasttests/pagination.spec.ts— new dedicated spec with two tests:page_sizeslicing andtotalaccuracy across pagesinfrastructure/types.ts— sharedPaginatedResponse<T>bridge type;marked
@deprecatedwith a cleanup checklist for when the SDK ships updatedtypes (page/page_size query params + response shape)