Skip to content

feat: delete raster layer#996

Merged
Eliav-Maimon merged 44 commits into
masterfrom
delete-raster-layer
Jul 23, 2026
Merged

feat: delete raster layer#996
Eliav-Maimon merged 44 commits into
masterfrom
delete-raster-layer

Conversation

@Eliav-Maimon

Copy link
Copy Markdown
Contributor

No description provided.

@Eliav-Maimon Eliav-Maimon changed the title Delete raster layer feat: delete raster layer Jul 9, 2026
@Eliav-Maimon
Eliav-Maimon requested a review from alebinson July 15, 2026 14:19

@alebinson alebinson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments

height: 60px;
min-width: 264px;
overflow-y: auto;
overflow-x: hidden;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove it, act differently

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Comment thread src/common/components/grid/cell-renderer/actions.cell-renderer.css Outdated

interface BuildOlTileLayerParams {
key: string;
protocol: 'WMTS' | 'XYZ';

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider to use it form LinkType enum

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now using LinkType

Comment thread src/common/components/ol-map/ol-tile-layer.utils.tsx Outdated
Comment thread src/common/components/ol-map/ol-tile-layer.utils.tsx Outdated
Comment thread src/discrete-layer/components/layer-details/raster/pp-map.utils.ts Outdated
Comment thread src/discrete-layer/components/layer-details/dialog.helpers.tsx
Comment thread src/discrete-layer/components/layers-results/layers-results.tsx
Comment thread src/discrete-layer/models/mapMenusManagerStore.ts Outdated
@@ -1485,16 +1488,31 @@ const DiscreteLayerView: React.FC = observer(() => {
)}
{permissions.isDeleteAllowed &&

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we might combine them in one component() which decide what to open. in this way VIEW will be more semantic

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue if open for it

@alebinson alebinson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg!

@Eliav-Maimon
Eliav-Maimon merged commit 0231ed4 into master Jul 23, 2026
3 checks passed
@Eliav-Maimon
Eliav-Maimon deleted the delete-raster-layer branch July 23, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants