feat: per-task tile merge report (added/merged/replaced counts + added-tile list) - #266
Open
shimoncohen wants to merge 18 commits into
Open
shimoncohen wants to merge 18 commits into
shimoncohen wants to merge 18 commits into
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…tile list Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…askExecutor Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
Open question — report-write failure handling Currently Best-effort is the proposed default, but if the report becomes a downstream dependency, silent loss may be wrong. Decide before merge. |
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Move the added/merged/replaced/skipped decision out of TaskExecutor into MergeReport.RecordOutcome; make the Record* counters private. Classification permutations now unit-tested directly on MergeReport; TaskExecutorTest keeps one end-to-end wiring test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
shimoncohen
requested review from
CL-SHLOMIKONCHA,
asafmas-rnd and
razbroc
and removed request for
asafmas-rnd
September 15, 2026 15:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
z/x/ylist of added tiles.REPORT:sinkconfig) at the path from the job'sAdditionalParams.ReportOutputPath(absent → log line only).How it works
TileMerger.MergeTilesgains anout MergeStatsoverload (TargetUsed,AnySourceUsed); old signature kept (CLI/tests untouched).TaskExecutorcomputesexistedBeforevia an exact-coordTileExists(defensiveCoordcopy —Data.TileExistsmutates its arg) and classifies each tile into aMergeReport, then finalizes → logs →ReportWriter.WriteReport(best-effort).ReportWriterresolves the S3 client lazily so FS-only deployments without AWS creds still boot.Spec / plan
docs/superpowers/specs/2026-09-15-tile-merge-report-design.mddocs/superpowers/plans/2026-09-15-tile-merge-report.mdFollow-up
Test Plan
dotnet build GpkgMerger.sln— 0 errorsdotnet test --filter TestCategory=unit— 1155 pass, 0 fail (+12 new: MergeStats, MergeReport, ReportWriter FS/S3/no-op, TaskExecutor added/merged/replaced/skipped)ReportOutputPathset (FS and S3) and confirm artifact contents + log line🤖 Generated with Claude Code