Fix multi-line strings in Tex and MathTex#4633
Open
alembcke wants to merge 1 commit intoManimCommunity:mainfrom
Open
Fix multi-line strings in Tex and MathTex#4633alembcke wants to merge 1 commit intoManimCommunity:mainfrom
alembcke wants to merge 1 commit intoManimCommunity:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Fixes Issue #4617. Prior to PR #4515 newlines within a Python string would be stripped by Latex. Since the PR processes the string prior to sending it to Latex, the Python string needs to be stripped of new lines prior to processing (this does not affect Latex new lines, only Python new lines).
Motivation and Explanation: Why and how do your changes improve the library?
To allow for multi-line strings when using
TexandMathTexfor code readability.Links to added or changed documentation pages
N/A
Further Information and Comments
I implemented this by replacing Python new lines with spaces, should I have used
self.arg_separatorinstead of a space? I assumed that users would expect a Python new line to result in a space in the final Latex written to the screen.Reviewer Checklist