Add ThreeDValueTracker class to value_tracker.py file#4628
Open
GoThrones wants to merge 12 commits intoManimCommunity:mainfrom
Open
Add ThreeDValueTracker class to value_tracker.py file#4628GoThrones wants to merge 12 commits intoManimCommunity:mainfrom
GoThrones wants to merge 12 commits intoManimCommunity:mainfrom
Conversation
…ex number(either in rectangular coordinate form or in polar form) or a tuple, list, string, or numpy array
for more information, see https://pre-commit.ci
…x, nan and inf values
for more information, see https://pre-commit.ci
…/ManimCE into add-threedvaluetracker
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
It adds a new class named ThreeDValueTracker.
Motivation and Explanation: Why and how do your changes improve the library?
In the existing file of value_tracker.py, there were only 2 classes: one was ValueTracker, which was supposedly to be used for 2D scenes, wherein only one of the number needs to continuously change w.r.t time. Another class was ComplexValueTracker which also works in 2D scenes and allows users to change 2 numbers continuously w.r.t time. However, there was nothing to allow users working in 3D scenes to changes 3 numbers simultaneously w.r.t time.
Example code which allows users to use ThreeDValueTracker:
Output video:
testThreeDValueTracker.mp4
Reviewer Checklist