Improve ValueTracker.set_value#4625
Open
GoThrones wants to merge 8 commits intoManimCommunity:mainfrom
Open
Conversation
…ex number(either in rectangular coordinate form or in polar form) or a tuple, list, string, or numpy array
for more information, see https://pre-commit.ci
…x, nan and inf values
GoThrones
force-pushed
the
improve-valuetracker-setvalue
branch
from
abfda7a to
7f23ef0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
It makes the set_value method of ValueTracker to take only those values which are either float, int, str and are not infinity or NAN or complex numbers. If someone passes complex number to set_value of ValueTracker, then it tells the user to use ComplexValueTracker.
Reviewer Checklist