Improvement to ComplexValueTracker.set_value#4624
Open
GoThrones wants to merge 5 commits intoManimCommunity:mainfrom
Open
Improvement to ComplexValueTracker.set_value#4624GoThrones wants to merge 5 commits intoManimCommunity:mainfrom
GoThrones wants to merge 5 commits intoManimCommunity:mainfrom
Conversation
…ex number(either in rectangular coordinate form or in polar form) or a tuple, list, string, or numpy array
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Presently, in the set_value method of ComplexValueTracker class, only a complex number of the form a+jb,can be passed as argument.
Overview: What does this pull request change?
This PR provides users with options to either provide a complex number, either in rectanguler coordinate system(a+jb) or in polar coordinate system(r,theta) or if the user is not providing a complex number of the form a+jb, then the following may also be accpeted: a float, int, str or a list, tuple or any Sequence of 2 numbers. When providing a complex number of the form (r, theta), theta may be in radians or degrees.
Reviewer Checklist