[Experimental] Fix image test#4618
Open
fmuenkel wants to merge 2 commits intoManimCommunity:experimentalfrom
Open
[Experimental] Fix image test#4618fmuenkel wants to merge 2 commits intoManimCommunity:experimentalfrom
fmuenkel wants to merge 2 commits intoManimCommunity:experimentalfrom
Conversation
chopan050
approved these changes
Mar 3, 2026
Member
There was a problem hiding this comment.
LGTM! This is the first step towards rendering ImageMobjects in OpenGL, very much needed.
For the record, PR #4233 rewrites the color system so that only VMobjects have a color (because it does not make sense that pure, non-renderable Mobjects have a color). Among the changes, it removes init_colors(), so it's good to note this PR in #4233.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Fixes
test_invert_imageintests/module/mobject/test_image.pyby overridingImageMobject.init_colors().Progress towards completing #4592.
Motivation and Explanation: Why and how do your changes improve the library?
The base
OpenGLMobject.__init__callsinit_colors()which in turn callsset_color(). Becauseinit_colors()runs afterImageMobjectinverts the image, the inverted values in the pixel array are overwritten.Furthermore, the test now select from the full range of values for 16 bit colors.
Links to added or changed documentation pages
Further Information and Comments
Reviewer Checklist