Conversation
|
To make this somewhat sustainable, we'd need to add this sort of check to pre-commit or the code quality pipeline. I'm not really convinced it is worth to add another dependency with another config file for this. Can this tool also be configured within
|
|
|
Okay. In the meantime I checked, we already have codespell in our pre-commit, so I'm against adding a second spellchecker tool. The config file should be removed from this PR. As for the other changes, I'm leaning towards merging them (even though they are effectively breaking changes). |
Overview: What does this pull request change?
Motivation and Explanation: Why and how do your changes improve the library?
I decided to spend a little bit of time familiarizing myself with Manim. One of the ways to do that is to spend some time making relatively safe changes like fixing spelling. I used the typos-cli to find potential issues, manually evaluated if the potential issues are actually issues, and made changes accordingly. I use the Pyright LSP rename utility so that names would be changed consistently.
Links to added or changed documentation pages
All of the typos were minor implementation changes that I don't expect to noticeably change in the documentation. If anything, some API docs will change but I did not check.
Further Information and Comments
Reviewer Checklist