Set default stroke width for SVG shapes without it#4487
Open
Eymeric65 wants to merge 5 commits intoManimCommunity:mainfrom
Open
Set default stroke width for SVG shapes without it#4487Eymeric65 wants to merge 5 commits intoManimCommunity:mainfrom
Eymeric65 wants to merge 5 commits intoManimCommunity:mainfrom
Conversation
Following SVG standard, when a stroke color is supplied without a line stroke, a line stroke is applied by default. This copy the behavior to manim
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following SVG standard, when a stroke color is supplied without a line stroke, a line stroke is applied by default. This copy the behavior to manim
Overview: What does this pull request change?
Motivation and Explanation: Why and how do your changes improve the library?
Basically I got some SVG that imported without line stroke and I got interested into how SVG worked, everything is parsed correctly just when you view it as an end user the browser apply a stroke on element that have stroke color even if they don't specify stroke width. Manim imported this without applying this underlying rule of SVG.
Any comment is welcome if I had wrongly interpreted SVG rule.
Links to added or changed documentation pages
Further Information and Comments
Reviewer Checklist