Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR]: gh-action #10150

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

digitronik
Copy link
Contributor

@digitronik digitronik commented May 28, 2020

Purpose or Intent

Guys, proposal for dropping travis and move to github action. Please add your views.

run will look like;
https://github.com/digitronik/integration_tests/actions/runs/118089757

Copy link
Contributor

@john-dupuy john-dupuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do you if this will show up in the Checks at the bottom of the PR like travis/PRT/lint does?

@digitronik
Copy link
Contributor Author

digitronik commented Jun 3, 2020

LGTM, do you if this will show up in the Checks at the bottom of the PR like travis/PRT/lint does?

Yes It will show up at bottom of PR; like fallowing snapshot.

Screenshot_2020-06-03_19-34-36

Copy link
Member

@ganeshhubale ganeshhubale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)
Nice PR 👍

@john-dupuy john-dupuy changed the title RFR: gh-action [1LP][RFR]: gh-action Jun 26, 2020
pull_request:
schedule:
# Run every day at 23:59 UTC
- cron: 59 23 * * *
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@digitronik why have a schedule here for the actions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mshriver In the absence of PRs, this will help to verify the installation doesn't have any dependency issue so I decided to run at least one time in a day.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants