Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update strings.xml #287

Merged
merged 2 commits into from
Aug 24, 2024
Merged

Update strings.xml #287

merged 2 commits into from
Aug 24, 2024

Conversation

airon90
Copy link

@airon90 airon90 commented Aug 5, 2024

Updated Italian translation

  • Added some missing keys
  • Translated some untranslated strings
  • Changed some translations
  • One key cannot be translated ("filter_bookmarked") as I don't know the context

Updated Italian translation

* Added some missing keys
* Translated some untranslated strings
* Changed some translations
* One key cannot be translated ("filter_bookmarked") as I don't know the context
</plurals>

<!-- Home -->
<string name="history">Cronologia</string>
<string name="stats">Statistiche</string>
<string name="mood_and_genres">Mood e generi</string>
<string name="account">Account</string>
<string name="account">Profilo</string>
<string name="quick_picks">Scelte rapide</string>
<string name="quick_picks_empty">Ascolta alcuni brani per generare le tue scelte rapide</string>
<string name="new_release_albums">Nuovi album in uscita</string>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update new_release_albums to not mention albums? Check the English string.

#276

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have fixed this, @lucasmz-dev

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DW it wasn't highlighted properly hence why #276 exists, but it's nice to highlight so that you don't have to do this again later :P

As suggested by @lucasmz-dev I removed the direct mention to albums in a string
@Malopieds Malopieds merged commit be0989a into Malopieds:dev Aug 24, 2024
1 check passed
@Malopieds
Copy link
Owner

/home/runner/work/InnerTune/InnerTune/app/src/main/res/values-it/strings.xml:181: Error: The plurals "n_elements" in values-it has no declaration in the base values folder; this can lead to crashes when the resource is queried in a configuration that does not match this qualifier [MissingDefaultResource]

~~~~~~~~~~~~~~~~~
Explanation for issues of type "MissingDefaultResource":
If a resource is only defined in folders with qualifiers like -land or -en,
and there is no default declaration in the base folder (layout or values
etc), then the app will crash if that resource is accessed on a device
where the device is in a configuration missing the given qualifier.

Weird thing it didn't crashed on the PR test, I'll fix that if you could give me the equivalent in Italian, or I'll use my Italian 101 x)

@airon90
Copy link
Author

airon90 commented Aug 24, 2024

@Malopieds I don't understand what should I translate. Anyway, in Italian language, the singular form of the sentence is "1 elemento" and the plural is "n elementi"

Malopieds pushed a commit that referenced this pull request Aug 24, 2024
* Update strings.xml

Updated Italian translation

* Added some missing keys
* Translated some untranslated strings
* Changed some translations
* One key cannot be translated ("filter_bookmarked") as I don't know the context

* Update Italian strings.xml

As suggested by @lucasmz-dev I removed the direct mention to albums in a string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants