Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Bump Makie compat to v0.21 #76

Closed
wants to merge 10 commits into from

Conversation

asinghvi17
Copy link
Member

This is mainly for testing so I can pull from and potentially fix a branch.

asinghvi17 and others added 6 commits March 9, 2024 19:11
This is not working at the moment because there are some strange interactions.
Maybe it would be better to simply use a GeoAxis and let GeoMakie handle the conversion logic, that is currently done in Tyler.
@asinghvi17
Copy link
Member Author

See #82, we should not merge this until that is solved.

@asinghvi17
Copy link
Member Author

Try this:

using Tyler, GLMakie
london = Rect2f(-0.0921, 51.5, 0.04, 0.025)
fig = Figure(); nax = LScene(fig[1, 1]); fig
m = Tyler.Map(london, figure = fig, axis = nax)
fig

You can see that the z-fighting begins immediately. I have a video up on Discord showing that as well, you can update the extent to the France example earlier using:

france_view = Tyler.Extents.Extent(X = (-21739.258606623473, 586505.0035158572), Y = (6.453166815536934e6, 6.930553746366132e6))
Tyler.update_tiles!(m, france_view)

and pan around to see the z-fighting happening.

@asinghvi17
Copy link
Member Author

@felixcremer could you try this branch now? I'm getting better results when I set the z scale to 1 instead of 0, which was done in the last commit.

@SimonDanisch
Copy link
Member

I mean mwe without Tyler! ;)

@asinghvi17
Copy link
Member Author

asinghvi17 commented May 12, 2024

I merged #78 into this as well, since it doesn't change too much and MakieOrg/GeoMakie.jl#207 removes the PROJ_RESCALE_FACTOR constant in any case.

Screenshot 2024-05-12 at 11 49 33 AM

Is the Tyler web-mercator math different from what is accepted?

@asinghvi17 asinghvi17 closed this Jul 9, 2024
@asinghvi17 asinghvi17 deleted the patch-2 branch July 9, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants