-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Bump Makie compat to v0.21 #76
Conversation
This is not working at the moment because there are some strange interactions. Maybe it would be better to simply use a GeoAxis and let GeoMakie handle the conversion logic, that is currently done in Tyler.
See #82, we should not merge this until that is solved. |
Try this: using Tyler, GLMakie
london = Rect2f(-0.0921, 51.5, 0.04, 0.025)
fig = Figure(); nax = LScene(fig[1, 1]); fig
m = Tyler.Map(london, figure = fig, axis = nax)
fig You can see that the z-fighting begins immediately. I have a video up on Discord showing that as well, you can update the extent to the France example earlier using: france_view = Tyler.Extents.Extent(X = (-21739.258606623473, 586505.0035158572), Y = (6.453166815536934e6, 6.930553746366132e6))
Tyler.update_tiles!(m, france_view) and pan around to see the z-fighting happening. |
@felixcremer could you try this branch now? I'm getting better results when I set the z scale to 1 instead of 0, which was done in the last commit. |
I mean mwe without Tyler! ;) |
I merged #78 into this as well, since it doesn't change too much and MakieOrg/GeoMakie.jl#207 removes the PROJ_RESCALE_FACTOR constant in any case. Is the Tyler web-mercator math different from what is accepted? |
This is mainly for testing so I can pull from and potentially fix a branch.