fill out some ignored API functions #113
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
useful if using Tyler outside of Makie
rafaqz
reviewed
Nov 27, 2024
| @@ -44,6 +44,8 @@ function unique_filename(url) | |||
| return string(hash(url)) | |||
| end | |||
|
|
|||
| file_ending(provider::TileProviders.Provider) = ".some_unknown_image_format" | |||
There was a problem hiding this comment.
Provider urls usually end with the image format after you strip the query
There was a problem hiding this comment.
Splitext(Geturl(provider, 0,0,0))[2] maybe?
On mobile so capitalization is a bit off. But if anyone wants to do this feel free to go ahead.
There was a problem hiding this comment.
You may have to strip the query after ? first
There was a problem hiding this comment.
URIs.URI(url).query/path, parses it into the parts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useful if using Tyler outside of Makie, and will make the code more portable to MapTiles in the future!