Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI improvements #63

Merged
merged 9 commits into from
Nov 18, 2024
Merged

CI improvements #63

merged 9 commits into from
Nov 18, 2024

Conversation

palday
Copy link
Collaborator

@palday palday commented Nov 16, 2024 •
edited
Loading

  • formatting (+ a format run)
  • spellcheck
  • additional Julia versions
  • wrap tests into testsets for better progress
  • bump Julia compat to current LTS (1.10)

Note

The only real changes are in the .yml and .toml files. Everything else is just formatting and wrapping tests in testsets.

github-actions[bot]
github-actions bot reviewed Nov 16, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

JuliaFormatter

src/eeg.jl|51|
src/eeg.jl|66|
src/eeg.jl|148|
src/eeg.jl|210|
src/extrapolation.jl|8|
src/extrapolation.jl|28|
src/interpolators.jl|24|
src/interpolators.jl|28|
src/interpolators.jl|59|
src/interpolators.jl|91|
src/interpolators.jl|114|
src/interpolators.jl|179|
src/interpolators.jl|185|
src/interpolators.jl|195|
src/interpolators.jl|213|
test/nb_example.jl|39|
test/nb_example.jl|42|
test/nb_example.jl|52|
test/nb_example.jl|60|
test/nb_example.jl|69|
test/nb_example.jl|74|
test/runtests.jl|40|
test/runtests.jl|46|
test/runtests.jl|53|
test/runtests.jl|67|
test/runtests.jl|70|
test/runtests.jl|75|
test/runtests.jl|85|
test/runtests.jl|88|
test/runtests.jl|94|
test/runtests.jl|101|
test/runtests.jl|106|
test/runtests.jl|117|
test/runtests.jl|159|
test/runtests.jl|169|
test/runtests.jl|174|
test/runtests.jl|180|
test/runtests.jl|183|
test/runtests.jl|188|
test/runtests.jl|194|
test/runtests.jl|197|
test/runtests.jl|211|
test/test-scripts.jl|6|
test/test-scripts.jl|22|
test/test-scripts.jl|25|
test/test-scripts.jl|29|
test/test-scripts.jl|57|
test/test-scripts.jl|66|
test/test-scripts.jl|77|
test/test-scripts.jl|86|
test/test-scripts.jl|90|

assets/write_template-positions-bin.jl Show resolved Hide resolved
docs/make.jl Show resolved Hide resolved
docs/make.jl Show resolved Hide resolved
docs/make.jl Show resolved Hide resolved
docs/src/topo_series.jl Show resolved Hide resolved
src/core-recipe.jl Show resolved Hide resolved
src/core-recipe.jl Show resolved Hide resolved
src/eeg.jl Show resolved Hide resolved
src/eeg.jl Show resolved Hide resolved
src/eeg.jl Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Nov 16, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

JuliaFormatter

test/runtests.jl|101|
test/runtests.jl|106|
test/runtests.jl|117|
test/runtests.jl|133|
test/runtests.jl|141|
test/runtests.jl|152|
test/runtests.jl|162|
test/runtests.jl|167|
test/runtests.jl|171|
test/runtests.jl|174|
test/runtests.jl|179|
test/runtests.jl|185|
test/runtests.jl|188|
test/runtests.jl|195|
test/runtests.jl|202|
test/test-scripts.jl|6|
test/test-scripts.jl|22|
test/test-scripts.jl|25|
test/test-scripts.jl|29|
test/test-scripts.jl|57|
test/test-scripts.jl|66|
test/test-scripts.jl|77|
test/test-scripts.jl|86|
test/test-scripts.jl|90|

src/eeg.jl Show resolved Hide resolved
src/eeg.jl Show resolved Hide resolved
src/eeg.jl Show resolved Hide resolved
src/eeg.jl Show resolved Hide resolved
src/extrapolation.jl Show resolved Hide resolved
test/runtests.jl Show resolved Hide resolved
test/runtests.jl Show resolved Hide resolved
test/runtests.jl Show resolved Hide resolved
test/runtests.jl Show resolved Hide resolved
test/runtests.jl Show resolved Hide resolved
@palday palday requested a review from behinger November 16, 2024 22:33
@palday palday mentioned this pull request Nov 16, 2024
Merged
@behinger behinger merged commit 07a95ea into master Nov 18, 2024
6 checks passed
@behinger behinger deleted the pa/formatting branch November 18, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@behinger behinger behinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@palday @behinger