Fix GLMakie embedding support #4848
Open
+13
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An exit handler was added to GLMakie in MakieOrg#4782 to ensure that all OpenGL resources are cleaned up, which will eventually call `close(::Screen)` and `destroy!(::Screen)`, which previously assumed that GLMakie owned `screen.glscreen` and would try calling GLFW functions on it. Now they will only do GLFW things if GLMakie owns the screen window. Also documented that embedders will need to implement `destroy!(::MyWindow)`.
|
I believe the benchmark failure is unrelated, maybe it's because I'm making the PR from a fork? |
|
Yep, benchmark CI doesn't run on PRs from forks unfortunately, because it (currently) has to write the image to a Gist. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An exit handler was added to GLMakie in #4782 to ensure that all OpenGL resources are cleaned up, which will eventually call
close(::Screen)anddestroy!(::Screen), which previously assumed that GLMakie ownedscreen.glscreenand would try calling GLFW functions on it. Now they will only do GLFW things if GLMakie owns the screen window. Also documented that embedders will need to implementdestroy!(::MyWindow).Relevant prior PR: #4073
I don't have the bandwidth for it right now, but in the future I'd like to try writing some unit tests for embedding support.
Type of change
Delete options that do not apply:
Checklist