Change ImageLike and VolumeLike deprecation warnings to errors #4685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffreyer
commented
Dec 19, 2024
src/conversions.jl
Outdated
Comment on lines
669
to
684
| function convert_arguments(::VolumeLike, x::RealVector, y::RealVector, z::RealVector, f::Function) | ||
| if !applicable(f, x[1], y[1], z[1]) | ||
| error("You need to pass a function with signature f(x, y, z). Found: $f") | ||
| end | ||
| # Verify grid regularity | ||
| is_regularly_spaced(x) || throw_range_error(x, "x", VolumeLike) | ||
| is_regularly_spaced(y) || throw_range_error(y, "y", VolumeLike) | ||
| is_regularly_spaced(z) || throw_range_error(z, "z", VolumeLike) | ||
|
|
||
| _x, _y, _z = ntuple(Val(3)) do i | ||
| A = (x, y, z)[i] | ||
| return reshape(A, ntuple(j -> j != i ? 1 : length(A), Val(3))) | ||
| end | ||
| # TODO only allow unitranges to map over since we dont support irregular x/y/z values | ||
|
|
||
| return (map(to_endpoints, (x, y, z))..., el32convert.(f.(_x, _y, _z))) | ||
| end |
There was a problem hiding this comment.
Note that this didn't previously warn and now errors (if the array spacing is not approximately the same)
Benchmark ResultsSHA: bad9945e84701b402b357840e29bb963508319c3 Warning These results are subject to substantial noise because GitHub's CI runs on shared machines that are not ideally suited for benchmarking.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TODO:
Type of change
Checklist
AddedUpdated unit tests for new algorithms, conversion methods, etc.AddedUpdated reference image tests for new plotting functions, recipes, visual options, etc.