fix: reintroduce vmin, vmax into get_ticks; addresses #4441

[thomvet]

Description

Fixes #4441
get_ticks now filters out values that are below vmin and vmax supplied to it.

Type of change

• [ x] Bug fix (non-breaking change which fixes an issue)

Checklist

• added appropriate test.
• other options seemed not relevant.

[thomvet]

Didn't expect this simple change to break something else; good thing the tests exist! I introduced another fix to address the issue (dont't use showoff on empty array).

But now I am running into #4416 when testing locally, i.e., Theme merging doesn't work anymore? Not obvious to me why the changes on get_ticks should have caused this!? Nevermind. Just didn't have the most current version of MakieCore locally. It should hopefully work on CI.

[jkrumbiegel]

The ticks are actually filtered later in the Axis code, as some tick algorithms return ticks outside the bounds, so you could either add that filtering to each algorithm, or just in a step after.

[thomvet]

Hm, I stumbled over this while working on a code for a new type of axis (TernaryAxis - for ternary plots), where I didn't have the further steps implemented yet.

I took the basic code from PolarAxis, so it might be that the problem is in there as well.

I'll check tomorrow.