Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference nonnumeric in doctring of sorter #486

Closed
wants to merge 3 commits into from

Conversation

KronosTheLate
Copy link
Contributor

I would have needed this pointer, so I added it when discovering the possibility.

@KronosTheLate KronosTheLate changed the title Update helpers.jl Reference nonnumeric in doctring of sorter Jan 22, 2024
Mainly to make it so that users do not have to find the online docs just to recall the syntax.
@jkrumbiegel
Copy link
Member

Closing this due to outdated doctests, but I also don't quite see the connection between sorter and nonnumeric. Any categorical variable will be sorted by default, that's not special about nonnumeric?

@KronosTheLate
Copy link
Contributor Author

It is just that I figured I was not the only one who would want to use integers as categorical variables, converted them to strings, and then wanted to sort them and thereby found the sorter function. For that situation it would be more apropriate to use nonnumeric, which is why I thought it made sende to mention it in the docstring. Also, the examples are usefull in ane case, so closing feels a little premature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants