Skip to content

Ensure Runner::run returns valid status #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
neerolyte wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ensure Runner::run returns valid status #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lib/guard/phpunit/runner.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,16 @@ def run_tests(paths, options)
# return false in case the system call fails with no status!
return false if $?.nil?

if $?.success? or tests_contain_failures? or tests_contain_errors?
# capture success so that if notifications alter the status stored in $? we still return the correct value
success = $?.success?

if success or tests_contain_failures? or tests_contain_errors?
notify_results(output, options)
else
notify_failure(options)
end

$?.success?
success
end

# Displays the start testing notification.
Expand Down Expand Up @@ -194,4 +197,4 @@ def execute_command(command)
end
end
end
end
end