Fix private message parsing when there is no colon prefix #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MahdiBM
approved these changes
Sep 13, 2024
|
The CI failures are unrelated, optimally I should just drop support for those older Swift versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
I was trying to use TwitchIRC to parse messages from recent-messages and found an uncovered case, so here's a fix and a new test.
In summary, the spec doesn't require a colon (
:) in the message, so whenever it's not present TwitchIRC was removing the first character of the message. In my case, I found this because it broke the emote indexes in the message.Let me know if you have any concerns about the change 😄
PS: Failing workflows seem unrelated.