Support for large workflow results#127
Merged
dmugtasimov merged 1 commit intomasterfrom Apr 28, 2025
Merged
Conversation
dmugtasimov
force-pushed
the
dmugtasimov/aed-154-update-js-sdk
branch
from
245de35 to
08f4ac2
Compare
abubakarsohail
approved these changes
Apr 23, 2025
| }, timeout); | ||
|
|
||
| promise.then((result) => { | ||
| clearTimeout(timer); |
Contributor
There was a problem hiding this comment.
You can clear the timeout in finally block
Contributor
Author
There was a problem hiding this comment.
No, I can't because timer is not available in finally {} scope, and setTimeout() cannot be moved to outer scope, because it requires reject
dmugtasimov
force-pushed
the
dmugtasimov/aed-154-update-js-sdk
branch
from
08f4ac2 to
41f605f
Compare
dmugtasimov
force-pushed
the
dmugtasimov/aed-154-update-js-sdk
branch
from
41f605f to
51649f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.