Skip to content

Fix CI #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
patrickelectric wants to merge 2 commits into
base: master
Choose a base branch
from
+5 −3
Open

Fix CI #727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6eeff67
setup: Use packaging over pkg_resources
patrickelectric Feb 11, 2026
ecf92c4
pyproject: Add packaging as dev depedency
patrickelectric Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ test = [
'mypy>=0.800',
]
dev = [
'packaging',
Copy link
Member

@fantix fantix Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need this in build-system.requires, so that people who install from the src tarball overriding cython-always, would succeed. It's a marginal case though.

'setuptools>=60',
'Cython~=3.0',
]
Expand Down
7 changes: 4 additions & 3 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,8 @@ def finalize_options(self):
need_cythonize = True

if need_cythonize:
import pkg_resources
from packaging.requirements import Requirement
from packaging.version import Version

# Double check Cython presence in case setup_requires
# didn't go into effect (most likely because someone
Expand All @@ -121,8 +122,8 @@ def finalize_options(self):
'please install {} to compile uvloop from source'.format(
CYTHON_DEPENDENCY))

cython_dep = pkg_resources.Requirement.parse(CYTHON_DEPENDENCY)
if Cython.__version__ not in cython_dep:
cython_dep = Requirement(CYTHON_DEPENDENCY)
if not cython_dep.specifier.contains(Version(Cython.__version__)):
raise RuntimeError(
'uvloop requires {}, got Cython=={}'.format(
CYTHON_DEPENDENCY, Cython.__version__
Expand Down
Loading