Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use different issue templates #3695

Merged
merged 7 commits into from
Jan 17, 2025
Merged

Conversation

KristjanESPERANTO
Copy link
Contributor

This PR will introduce different issue templates for bug reports, feature requests and so on on GitHub. There is still room for fine-tuning, but it's reached a state to show it to you and get feedback.

I think that this can lead to better bug reports.

You can see the result in my repo: https://github.com/KristjanESPERANTO/MagicMirror/issues/new/choose

Feel free to create new issues for testing.

What do you think? Do we want to pursue this further?

Copy link
Collaborator

@rejas rejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no way as far as I know to test this locally, so I am fine with this being tested "live" What do you think @khassel @sdetweil ?

@khassel
Copy link
Collaborator

khassel commented Jan 14, 2025

There is no way as far as I know to test this locally

did some testing using the fork of @KristjanESPERANTO

so I am fine with this being tested "live" What do you think @khassel @sdetweil ?

@rejas I'm fine with live testing. Currently the PR is based on develop so "live" testing would start in April ...

So from my side after merging on develop we could cherry pick the commit (without changelog stuff) and push it on master too. So we would have real live testing. Update notification is no problem, it reports only new versions on master if a new tag is applied.

@sdetweil
Copy link
Collaborator

i agree, no local testing, don't see why not pushing to
master as soon as ready.

@khassel khassel merged commit 77fe011 into MagicMirrorOrg:develop Jan 17, 2025
11 checks passed
@khassel
Copy link
Collaborator

khassel commented Jan 17, 2025

@rejas are you fine with cherry picking this on master?

@rejas
Copy link
Collaborator

rejas commented Jan 17, 2025

@rejas are you fine with cherry picking this on master?

Absolutely

@khassel
Copy link
Collaborator

khassel commented Jan 17, 2025

o.k., will do it ...

khassel added a commit that referenced this pull request Jan 17, 2025
This PR will introduce different issue templates for bug reports,
feature requests and so on on GitHub. There is still room for
fine-tuning, but it's reached a state to show it to you and get
feedback.

I think that this can lead to better bug reports.

You can see the result in my repo:
https://github.com/KristjanESPERANTO/MagicMirror/issues/new/choose

Feel free to create new issues for testing.

What do you think? Do we want to pursue this further?
# Conflicts:
#	CHANGELOG.md
@khassel
Copy link
Collaborator

khassel commented Jan 17, 2025

it's live now ...

@rejas
Copy link
Collaborator

rejas commented Jan 17, 2025

Looks neat. Lets see if people can read this better :-)

@sdetweil
Copy link
Collaborator

might have to add text under 'logs' for the system info.. most newish users still don't know what/where to find that
(and pm2 involved very often too)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants