Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add address and ipWhitelist to all test configs #3585

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

khassel
Copy link
Collaborator

@khassel khassel commented Oct 11, 2024

All test configs have been updated to allow full external access, allowing for easier debugging (especially when running as a container)

@khassel khassel requested a review from rejas October 11, 2024 21:58
@sdetweil
Copy link
Collaborator

just added 6 configs today, sorry

@khassel
Copy link
Collaborator Author

khassel commented Oct 11, 2024

just added 6 configs today, sorry

on your fork or here?

@sdetweil
Copy link
Collaborator

on my fork. i'll fix it..

@sdetweil
Copy link
Collaborator

one other thing, relative to test..
I was trying to do individual tests, via npm start with MM_CONFIG_FILE=test/configs/....
but
the test path isn't enabled unless JEST is running.. (so couldn't load the ics file)
so had to define that env var (as something) to get the path
was worried about other side effects

@khassel
Copy link
Collaborator Author

khassel commented Oct 11, 2024

the test path isn't enabled unless JEST is running.. (so couldn't load the ics file)

I added this with the last release and can revert it (with another PR) if you want. I didn't think of your use case

@sdetweil
Copy link
Collaborator

I can put it back with mine, just wanted to make sure there was no other intent

@khassel
Copy link
Collaborator Author

khassel commented Oct 11, 2024

o.k., it was this change:

grafik

@rejas rejas merged commit 3d1e8ab into MagicMirrorOrg:develop Oct 12, 2024
8 checks passed
@khassel khassel deleted the testconf branch October 23, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants