Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint #3551

Closed
wants to merge 4 commits into from
Closed

Eslint #3551

wants to merge 4 commits into from

Conversation

bugsounet
Copy link
Contributor

@bugsounet bugsounet commented Sep 22, 2024

testing with eslint v9.x

1st step: test:js

  • need to rewrite eslintrc to flat config

2st step: test with global test suite (not reviewed actually)

3st step: add again "eslint-plugin-import" (if possible)

@bugsounet bugsounet marked this pull request as draft September 22, 2024 13:18
@bugsounet
Copy link
Contributor Author

step 1:

Not to bad :)

> [email protected] test:js
> eslint .


/home/runner/work/MagicMirror/MagicMirror/tests/unit/functions/server_functions_spec.js
  [22](https://github.com/MagicMirrorOrg/MagicMirror/actions/runs/10981592648/job/30488817149?pr=3551#step:5:23):4  warning  Unused eslint-disable directive (no problems were reported)

✖ 1 problem (0 errors, 1 warning)
  0 errors and 1 warning potentially fixable with the `--fix` option.

@KristjanESPERANTO
Copy link
Contributor

I have already converted a few projects to ESLint 9. Let me know when your PR is ready for a review. I'll be happy to take a look at it. I don't want to bother you with comments in the middle of the process 🙂

@bugsounet
Copy link
Contributor Author

Perfect if you done it, because i have no many time actually ! ;)

@bugsounet bugsounet closed this Sep 25, 2024
@bugsounet bugsounet deleted the eslint branch September 25, 2024 06:27
rejas pushed a commit that referenced this pull request Sep 25, 2024
Since PR #3551 was not yet complete, I made my own attempt.

1. Update to ESLint v9.
2. Replace deprecated `.eslintrc.json` and `.eslintignore` by flat
config `eslint.config.mjs`.
3. Adapt `check_config.js` to use flat config.
4. Since `eslint-plugin-import` still doesn't support ESLint v9 I
removed it. We can add it back when it does support v9.
5. Run tests `npm run check:js` and `npm run config:check`.
6. In order not to overload this PR, I have not yet activated more
additional rules - there are some useful ones in the new plugin
`@eslint/js`.

@bugsounet, please don't take it as an offence that I have created a
competing PR. The migration to ESLint v9 has been burning under my nails
for some time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants