Skip to content

Conversation

sdetweil
Copy link
Collaborator

@sdetweil sdetweil commented Oct 31, 2023

Fixes: #3256

BUT.. the testcase is inconclusive.. as the code FAILS without the fix, BUT somehow RETURNS 0 entries..
in real life run the node helper fails, and all calendar processing stops.

@sdetweil
Copy link
Collaborator Author

this fails cause of the other calendar fix failure.

@sdetweil sdetweil changed the title fix rrule.between crash on bad dates #3256 fix crash on rrule.between returned bad dates #3256 Oct 31, 2023
@sdetweil sdetweil requested a review from rejas November 1, 2023 12:52
@sdetweil
Copy link
Collaborator Author

sdetweil commented Nov 7, 2023

because they produced errors in prettier about no ruleset. same as the ics

@rejas rejas merged commit b300191 into MagicMirrorOrg:develop Nov 7, 2023
@sdetweil sdetweil deleted the fix_bad_rrule branch July 15, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants