-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Override Notification Option to Weather Module #3178
Added Override Notification Option to Weather Module #3178
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## develop #3178 +/- ##
===========================================
- Coverage 26.15% 25.97% -0.19%
===========================================
Files 53 54 +1
Lines 11502 11621 +119
===========================================
+ Hits 3008 3018 +10
- Misses 8494 8603 +109
... and 2 files with indirect coverage changes 📢 Have feedback on the report? Share it here. |
Could you check the jsdoc warnings here: https://github.com/MichMich/MagicMirror/actions/runs/6105958927?pr=3178 @NolanKingdon ? |
…on/MagicMirror into weather-override-notification
Thx for the work @NolanKingdon will merge it now. Could you also provide a PR to update the docs in the https://github.com/MichMich/MagicMirror-Documentation/ repo? |
Fixes #3126
Added the option
allowOverrideNotification
toweather.js
. This allows the module to receive theCURRENT_WEATHER_OVERRIDE
notification. The expected payload for this notification is a full/partialweatherObject
that is used to supplement/replace the existingweatherObject
returned by whichever weather provider is in use.No visual changes.
First time contributing - let me know if I've missed something 🙂