3rd party modules updater for updatenotification

[bugsounet]

#3142

Added my (modified) updater main core into updatenotification default module

Missing: callback display in MM² (i will code it after)

new part of configuration added:

		updates: [
			// array of module update commands
			{
				// with embed npm script
				"MMM-Test": "npm run update"
			},
			{
				// with "complex" process
				"MMM-OtherSample": "rm -rf package-lock.json && git reset --hard && git pull && npm install"
			},
			{
				// with git pull && npm install
				"MMM-OtherSample2": "git pull && npm install"
			},
			{
				// with a simple git pull
				"MMM-OtherSample3": "git pull"
			}
		],
		updateTimeout: 2 * 60 * 1000, // max update duration
		updateAutorestart: false // autoRestart MM when update done ?

@khassel: i need your help
I don't use docker, maybe you can help me for this:
How can i check if MM² is running inside a docker ? (from MM² main core)
Actually, I check if we use pm2 or not.
I have to check if docker is used or not too
last time you tell me: "you can't use updater with docker", so I want to check and deny any update if docker used

[bugsounet]

humm... I don't want to push new package-lock now but it's needed

[codecov-commenter]

Codecov Report

Merging #3150 (b7dffce) into develop (66b29ec) will increase coverage by 0.48%.
Report is 1 commits behind head on develop.
The diff coverage is 39.71%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           develop    #3150      +/-   ##
===========================================
+ Coverage    25.19%   25.68%   +0.48%     
===========================================
  Files           54       55       +1     
  Lines        11933    12202     +269     
===========================================
+ Hits          3007     3134     +127     
- Misses        8926     9068     +142     

Files	Coverage Δ
modules/default/calendar/calendar.js	0.00% <ø> (ø)
modules/default/updatenotification/node_helper.js	78.84% <50.00%> (+5.51%)	⬆️
...s/default/updatenotification/updatenotification.js	0.00% <0.00%> (ø)
...odules/default/updatenotification/update_helper.js	45.08% <45.08%> (ø)

... and 1 file with indirect coverage changes

[bugsounet]

I think that pm2 will correct Vulnerabilities soon

[khassel]

How can i check if MM² is running inside a docker ? (from MM² main core)
last time you tell me: "you can't use updater with docker", so I want to check and deny any update if docker used

are you talking of restarting? Because updater in general has no problem with docker ...

Simple method is to check if the file /.dockerenv exists.

[bugsounet]

maybe it's better to use 'pm2 prettylist' with child_process exec function instead of the pm2 library.
It will correct Vulnerabilities, no ?
because I think they are in no hurry to fix this

[bugsounet]

ah... how solve this translations_spec.js error ?

I have added some new translations part in en and fr json file
I'm not able to translate all ;) ;)

what's missing ?

[bugsounet]

Ok i found: de json file is considered as default (I thought it was 'en')
I will see with my de translator :)

[khassel]

Ok i found: de json file is considered as default (I thought it was 'en')

yes, there was a reason to switch but I forgot it ...

I will see with my de translator :)

can review this before merge ...

[bugsounet]

yes @khassel : maybe this

[bugsounet]

It's not totaly Done:

• I have to Clean some not needed parts
• make Class Docs

[bugsounet]

@rejas: It's ok for me for review

Can you restart again test suite because ... as usual "ReferenceError: moment is not defined" error is again there ...
thx ;)

[bugsounet]

Ah the misery, ... I hate resolving a conflict in the package-lock.json

I'll leave it like this for now, we'll fix it when we push it

You have to test anyway

[bugsounet]

@rejas:

will we put it in place for v2.26.x?
I don't think we will have time to do the tests/review and write the doc

[rejas]

Next version is 2.25, so lets move it to v2.26, ok?

[bugsounet]

@rejas

Hi, this seems ready for review

[khassel]

concerning running as docker container: Restarting should work with this code (if container is set to restart automatically), will test this after this is merged on develop.

[bugsounet]

This test suite is very random :/
it works half the time locally...

Test Suites: 40 passed, 40 total
Tests:       574 passed, 574 total
Snapshots:   9 passed, 9 total

ping: @rejas

what do we do with this PR?
Merge it or review again ;)

[bugsounet]

ping @rejas
ping: connect: Network is unreachable

[rejas]

lets see how it behaves in develop :-)

[rejas]

could you bring it up to the latest develop so we see the tests become green? thx for your patience!

[khassel]

@bugsounet I was looking for the new restart config option for updatenotification but couldn't find this in the documentation repo (maybe I'm blind).

So can you please provide a Documentation-PR for the new features you implemented here? Thanks!

[bugsounet]

It's planned ;)
I will do it before release, don't worry ;)

[bugsounet]

Finally... I'm not sure that I will have time to write it before release :/