add try / catch on mode_helper loading

MagicMirrorOrg · Oct 5, 2024 · d49c7b7 · d49c7b7
1 parent f51fbe3
commit d49c7b7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -22,6 +22,7 @@ _This release is scheduled to be released on 2025-01-01._
 ### Fixed
 
 - [updatenotification] Fix pm2 using detection when pm2 script is in MagicMirror root folder (#3576)
+- [core] Fix loading node_helper of modules: avoid black screen, display errors and continue loading with next module (#xxxx)
 
 ## [2.29.0] - 2024-10-01
 

diff --git a/js/app.js b/js/app.js
@@ -197,7 +197,13 @@ function App () {
 
 		// if the helper was found
 		if (loadHelper) {
-			const Module = require(helperPath);
+			let Module;
+			try {
+				Module = require(helperPath);
+			} catch (e) {
+				Log.error(`Error when loading ${moduleName}:`, e.message);
+				return;
+			}
 			let m = new Module();
 
 			if (m.requiresVersion) {