Skip to content

Commit

Permalink
fix access denied crash writing js/positions.js #3651
Browse files Browse the repository at this point in the history
  • Loading branch information
sdetweil committed Dec 10, 2024
1 parent 5232f46 commit 30e1d09
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ _This release is scheduled to be released on 2025-01-01._

- [core] Run code style checks in workflow only once.
- [core] fix animations export #3644 only on server side
- [core] fix Access Denied crash writing js/positions.js (on synology nas) #3651. new message, MM starts, but no modules showing, positions list empty

### Removed

Expand Down
7 changes: 6 additions & 1 deletion js/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,12 @@ module.exports = {
modulePositions.push(positionName);
}
});
fs.writeFileSync(discoveredPositionsJSFilename, `const modulePositions=${JSON.stringify(modulePositions)}`);
try {
fs.writeFileSync(discoveredPositionsJSFilename, `const modulePositions=${JSON.stringify(modulePositions)}`);
}
catch (error) {
console.error("unable to write js/positions.js with the discovered module positions\nmake the MagicMirror/js folder writeable by the user starting MagicMirror");
}
}
// return the list to the caller
return modulePositions;
Expand Down

0 comments on commit 30e1d09

Please sign in to comment.