fix: vendor add buy and add buyp commands
#11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensbodal
changed the title
add buy and add buyp commandsadd buy and add buyp commands
vendor `add buy` and `add buyp` commands should be fixed. Added a new vendor `buymax` command * Buys the maximum amount of an item (by exact name) based on your current * pyreal count. * Need to specify cost of item e.g. ``` /mt vendor addmax Trade Note (250,000)|287500 ```
jensbodal
force-pushed
the
fix/vendor-addbuy-commands
branch
from
9550367
to
e191caf
Compare
|
Can you elaborate on what the issue with "add buy" and "add buyp" were? Also, the buymax command is very nice. |
|
To put it simply, the commands did not work for me. I'm not sure if this has something to do with the emulator (gdleac). From what I remember from retail I'm not sure how this would work without subscribing to the approach vendor filter so that you can obtain the WOs from their inventory. The vendor WOs aren't available just because the vendor is open, I believe they're only available as part of the event which triggers upon opening the vendor. I'm sure these commands worked before as they wouldn't be there otherwise, but I wasn't able to get them to work until I did it his way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vendor
add buyandadd buypcommands should be fixed.Added a new vendor
buymaxcommande.g.