Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC-493-Add Api links to SQL and Redis #525

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

DOC-493-Add Api links to SQL and Redis #525

wants to merge 14 commits into from

Conversation

dlozina-macrometa
Copy link
Contributor

  • Redis update for 17.12

dlozina-macrometa and others added 9 commits December 21, 2022 10:49
@vercel
Copy link

vercel bot commented Dec 23, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docs ❌ Failed (Inspect) Feb 23, 2023 at 5:25PM (UTC)

diana-macrometa
diana-macrometa approved these changes Dec 23, 2022
View reviewed changes
Copy link
Contributor

@diana-macrometa diana-macrometa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jamesm-macrometa
jamesm-macrometa approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@jamesm-macrometa jamesm-macrometa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I would merge the two notes together so we don't have stacked note boxes.

docs/queryworkers/redis/index.md Show resolved Hide resolved
docs/queryworkers/redis/index.md Outdated Show resolved Hide resolved
docs/queryworkers/redis/index.md Outdated Show resolved Hide resolved
docs/queryworkers/redis/index.md Outdated Show resolved Hide resolved
@diana-macrometa diana-macrometa changed the base branch from main to 17-12-release February 13, 2023 15:07
@diana-macrometa
Copy link
Contributor

@dlozina-macrometa, please finish this PR

@diana-macrometa
Copy link
Contributor

@dlozina-macrometa, how's this going?

Base automatically changed from 17-12-release to main April 17, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesm-macrometa jamesm-macrometa jamesm-macrometa approved these changes

@diana-macrometa diana-macrometa diana-macrometa approved these changes

Assignees
No one assigned
Labels
DO NOT MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlozina-macrometa @diana-macrometa @jamesm-macrometa