Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing internal tests, part 1 #1387

Merged
merged 3 commits into from
Nov 26, 2020

Conversation

mahrud
Copy link
Member

@mahrud mahrud commented Jul 10, 2020

This PR is intended for fixing the remaining broken internal tests in order to:

  • close engine tests ignored since Aug 2019 #1213:
    • goals/ISSAC-97.m2 (Failed)
    • goals/gbZZ.m2 (Failed)
    • goals/joswig.m2 (Timeout)
    • quarantine/2-homog-bug.m2 (Failed)
    • quarantine/C05.m2 (Failed)
    • quarantine/HH.m2 (Failed)
    • quarantine/issac-97.m2 (Failed) (added in PrimaryDecomposition, MinimalPrimes, Saturation #1385)
    • quarantine/ker8.m2 (Failed)
    • quarantine/lapack.m2 (Failed)
    • quarantine/newlines.m2 (Failed)
    • quarantine/testmulti.m2 (Failed)
    • engine/gb-bench.m2 (Timeout) (closed in PrimaryDecomposition, MinimalPrimes, Saturation #1385)
    • engine/normal.m2 (Failed)
    • engine/raw-decompose.m2 (Failed)
    • engine/raw-freemodule.m2 (Failed)
    • engine/raw-monomial.m2 (Failed)
    • engine/raw-numerics.m2 (Failed)
    • engine/raw-res.m2 (Failed)
    • engine/raw-ring.m2 (Failed); two remain to close equality of raw rings #1086:
      • assert(raw RR_53 === rawRR(53))
      • assert(raw CC_53 === rawCC(53))
    • engine/raw-ring2.m2 (Failed)
    • engine/raw-ring3.m2 (Failed)
    • engine/raw-subduction.m2 (Failed)
    • engine/raw.m2 (Failed)
    • engine/raw3.m2 (Failed)
    • engine/test-linalg.m2 (Failed)

When that's done, it would be good to also improve the tests.

@mahrud mahrud added the contributions welcome New contributions are welcome in this pull request. label Jul 10, 2020
@mahrud mahrud changed the base branch from master to development July 10, 2020 12:40
@mahrud
Copy link
Member Author

mahrud commented Sep 21, 2020

@pepperhdj @dylanpeifer I just rebased this PR on top of development and make the ctest tests to also run on macos. Feel free to use this PR if you'd like, both of you should have push access.

@dylanpeifer
Copy link
Contributor

For engine/raw_res.m2, the problem appears to be in the printing of a RawComputation. The example that fails is real projective plane, algorithm 0. If we add semicolons to the end of lines 123, 124, and 125 (which suppresses printing the object returned by rawResolution, rawGBSetStop, and rawStartComputation) the assertions pass. The actual error message that appears can be found in the function BettiDisplay::entry, which is line 71 in e/betti.cpp, but we're not sure how control passes to this function or why the object is in a bad state when this function is called. Any suggestions?

@mahrud mahrud marked this pull request as ready for review November 25, 2020 18:55
@mahrud mahrud removed the draft label Nov 25, 2020
@mahrud mahrud changed the title WIP: Fixing internal tests Fixing internal tests, part 1 Nov 25, 2020
@mahrud
Copy link
Member Author

mahrud commented Nov 25, 2020

We should merge this before the next version and open a new PR for the next batch of tests to fix.

@DanGrayson DanGrayson merged commit c65b7e4 into Macaulay2:development Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributions welcome New contributions are welcome in this pull request. waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants