Do not blindly trust UNIX file attributes from MS-DOS.#183
Open
sesse wants to merge 1 commit intoMacPaw:masterfrom
Open
Do not blindly trust UNIX file attributes from MS-DOS.#183sesse wants to merge 1 commit intoMacPaw:masterfrom
sesse wants to merge 1 commit intoMacPaw:masterfrom
Conversation
Several archives made with old MS-DOS archivers will contain garbage in the UNIX permissions field. unar does not trust such file permissions in general for regular files, but it does if they are directories or special files (like symlinks). This can cause issues, e.g.: http://checkpoint.untergrund.net/files/ReBoy_v1.1a.zip unpacks successfully, but directories do not have the appropriate permissions and the result is basically unreadable without further chmod-ing. https://ftp.untergrund.net/users/irokos/magz/canadian_born_coders/aft-11.zip fails unpacking; it believes two of the files are symlinks, and one of them has a file name that is so long that symlink() fails. Both unpack successfully using unzip, which verifies UNIX permissions against MS-DOS permissions; all files must be user-readable, directories must always be user-executable, and the read-only bit must be the opposite of the user-writable permission. If they do not match, the UNIX permissions are ignored. Implement the same logic, so that the two files above extract successfully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several archives made with old MS-DOS archivers will contain garbage in the UNIX permissions field. unar does not trust such file permissions in general for regular files, but it does if they are directories or special files (like symlinks). This can cause issues, e.g.:
http://checkpoint.untergrund.net/files/ReBoy_v1.1a.zip unpacks successfully, but directories do not have the appropriate permissions and the result is basically unreadable without further chmod-ing.
https://ftp.untergrund.net/users/irokos/magz/canadian_born_coders/aft-11.zip fails unpacking; it believes two of the files are symlinks, and one of them has a file name that is so long that symlink() fails.
Both unpack successfully using unzip, which verifies UNIX permissions against MS-DOS permissions; all files must be user-readable, directories must always be user-executable, and the read-only bit must be the opposite of the
user-writable permission. If they do not match, the UNIX permissions are ignored. Implement the same logic, so that the two files above extract successfully.