Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GitHub Tomorrow Style #1289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

elsiehupp
Copy link

"GitHub Tomorrow" is a preview-pane theme that combines the basic formatting of the GitHub preview-pane theme with the colors of the Tomorrow edit-pane theme. I created this because there was no dark-mode preview-pane theme that looked nice with the Tomorrow+ edit-pane theme. The preview-pane background color is slightly lighter than the edit-pane background color in order to provide contrast with Tomorrow-themed inline code blocks.

I tested this somewhat, and it seems to work, though I ran into several limitations with the rendering engine:

  • ::selection { background-color } does not work as expected (the rendered color is incorrect).
  • li::before { ... } does not seem to be recognized at all.
  • a code, a tt { text-decoration: none; } does not seem to be recognized.

Please do let me know if there’s anything you’d like me to change in order for this to be merged. Thanks!

"GitHub Tomorrow" is a preview-pane theme that combines the basic formatting of the GitHub preview-pane theme with the colors of the Tomorrow edit-pane theme. I created this because there was no dark-mode preview-pane theme that looked nice with the Tomorrow+ edit-pane theme. The preview-pane background color is slightly lighter than the edit-pane background color in order to provide contrast with Tomorrow-themed inline code blocks.
@elsiehupp
Copy link
Author

I replaced a handful of accidental tab characters with spaces and squashed my existing commit, but it doesn't seem to have propagated to this pull request, yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant