-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spelling #1226
Open
jsoref
wants to merge
24
commits into
MacDownApp:master
Choose a base branch
from
jsoref:spelling
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Spelling #1226
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
90ede21
spelling: accessory
jsoref 3d707a6
spelling: ambiguous
jsoref 556f04a
spelling: appreciate
jsoref 1af0723
spelling: background
jsoref 056a26f
spelling: characters
jsoref 974a481
spelling: convenience
jsoref 114edd0
spelling: default
jsoref 78056f5
spelling: dimension
jsoref 8060bfc
spelling: document
jsoref c6a62c6
spelling: grammar
jsoref 0a4fa85
spelling: language
jsoref 3661ea0
spelling: macdown
jsoref eabfd8a
spelling: macos
jsoref f7c8e38
spelling: multiplier
jsoref e6c79b5
spelling: occurrences
jsoref 4473402
spelling: omitted
jsoref 3837e17
spelling: overridden
jsoref e8a784a
spelling: possible
jsoref 098ab44
spelling: preferences
jsoref 0f74e58
spelling: safety
jsoref 236cc1d
spelling: statements
jsoref cdb6344
spelling: strikethrough
jsoref 2e6b820
spelling: suppresses
jsoref 7d76dd9
spelling: would
jsoref File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -73,14 +73,14 @@ - (instancetype)init | |
@dynamic firstVersionInstalled; | ||
@dynamic latestVersionInstalled; | ||
@dynamic updateIncludesPreReleases; | ||
@dynamic supressesUntitledDocumentOnLaunch; | ||
@dynamic suppressesUntitledDocumentOnLaunch; | ||
@dynamic createFileForLinkTarget; | ||
|
||
@dynamic extensionIntraEmphasis; | ||
@dynamic extensionTables; | ||
@dynamic extensionFencedCode; | ||
@dynamic extensionAutolink; | ||
@dynamic extensionStrikethough; | ||
@dynamic extensionStrikethrough; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I suspect that this is a user breaking change |
||
@dynamic extensionUnderline; | ||
@dynamic extensionSuperscript; | ||
@dynamic extensionHighlight; | ||
|
@@ -235,7 +235,7 @@ - (void)cleanupObsoleteAutosaveValues | |
* Note that since this is called only when the user launches the app the first | ||
* time, new preferences that breaks backward compatibility should NOT be put | ||
* here. An example would be adding a boolean config to turn OFF an existing | ||
* functionality. If you add the defualt-loading code here, existing users | ||
* functionality. If you add the default-loading code here, existing users | ||
* upgrading from an old version will not have this method invoked, thus | ||
* effecting app behavior. | ||
* | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,7 @@ | |
<array> | ||
<dict> | ||
<key>CFBundleURLName</key> | ||
<string>Macdown custom control</string> | ||
<string>MacDown custom control</string> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This may be significant? |
||
<key>CFBundleURLSchemes</key> | ||
<array> | ||
<string>x-macdown</string> | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect that this is a user breaking change