Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🗃️(dashboard) add company-related fields to the Entity model #360

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

ssorin
Copy link
Collaborator

@ssorin ssorin commented Jan 27, 2025

Purpose

In order to manage consents, we need to retrieve specific information for each entity corresponding to the delivery point.

In this context, the following information fields must be added to the Entity model:
company type, legal form, trade name, siret, naf, main address, address complement, zip code, and city.

Proposal

  • add the new Entity fields
  • add validators for SIRET, NAF, and zip code.
  • add factory methods to support these additions.

@ssorin ssorin added improvement needs review dashboard Item related to the Dashboard service labels Jan 27, 2025
@ssorin ssorin self-assigned this Jan 27, 2025
@ssorin ssorin requested a review from jmaupetit January 27, 2025 16:16
@ssorin ssorin marked this pull request as ready for review January 27, 2025 16:16
Copy link
Member

@jmaupetit jmaupetit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/dashboard/apps/core/models.py Outdated Show resolved Hide resolved
@ssorin ssorin force-pushed the feature/dashboard/add-entity-information-fields branch from 32c8f39 to 42e792c Compare January 30, 2025 08:35
@ssorin ssorin force-pushed the feature/dashboard/add-entity-information-fields branch from 42e792c to 212f0b8 Compare January 30, 2025 09:10
New fields include company_type, legal_form, trade_name, siret, naf, and address fields.
Validators for SIRET, NAF, and zip code have been integrated.
Factory methods and migrations are updated to support these additions.
@ssorin ssorin force-pushed the feature/dashboard/add-entity-information-fields branch from 212f0b8 to 2785af8 Compare January 30, 2025 09:11
@ssorin ssorin merged commit ce08da3 into main Jan 30, 2025
9 of 10 checks passed
@ssorin ssorin deleted the feature/dashboard/add-entity-information-fields branch January 30, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard Item related to the Dashboard service improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants